Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1964)

Issue 2408043002: Revert of [testing/script] Switch run_telemetry_as_googletest.py to produce full json results format (Closed)

Created:
4 years, 2 months ago by loyso (OOO)
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [testing/script] Switch run_telemetry_as_googletest.py to produce full json results format (patchset #2 id:20001 of https://codereview.chromium.org/2403913002/ ) Reason for revert: Speculatively reverting this patch (suggested by findit) to see if it fixes Mac telemetry unit tests. https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/8276 https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/8277 Original issue's description: > [testing/script] Switch run_telemetry_as_googletest.py to produce full json results format > > BUG=649762 > > Committed: https://crrev.com/caa3b797728c9337fcea7d108a087d005fa7f451 > Cr-Commit-Position: refs/heads/master@{#424206} TBR=kbr@chromium.org,dpranke@chromium.org,nednguyen@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=649762 Committed: https://crrev.com/12b54d66ba1ce9e7a6c729fdf136b5b5c257b6f2 Cr-Commit-Position: refs/heads/master@{#424341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M testing/scripts/run_telemetry_as_googletest.py View 2 chunks +18 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
loyso (OOO)
Created Revert of [testing/script] Switch run_telemetry_as_googletest.py to produce full json results format
4 years, 2 months ago (2016-10-11 02:04:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2408043002/1
4 years, 2 months ago (2016-10-11 02:04:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-11 02:05:26 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/12b54d66ba1ce9e7a6c729fdf136b5b5c257b6f2 Cr-Commit-Position: refs/heads/master@{#424341}
4 years, 2 months ago (2016-10-11 02:10:10 UTC) #7
Dirk Pranke
lgtm
4 years, 2 months ago (2016-10-11 18:07:58 UTC) #8
nednguyen
4 years, 1 month ago (2016-11-07 15:07:19 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2480273002/ by nednguyen@google.com.

The reason for reverting is: Reason for revert:
Mac 10.10 Tests & Mac 10.11 Tests are now swarmed:
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests...

https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.11%20Tests....

Powered by Google App Engine
This is Rietveld 408576698