|
|
Description[testing/script] Switch run_telemetry_as_googletest.py to produce full json results format
BUG=649762
Committed: https://crrev.com/caa3b797728c9337fcea7d108a087d005fa7f451
Cr-Commit-Position: refs/heads/master@{#424206}
Patch Set 1 #Patch Set 2 : Update flag type #Messages
Total messages: 22 (10 generated)
nednguyen@google.com changed reviewers: + dpranke@chromium.org, kbr@chromium.org
The CQ bit was checked by nednguyen@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by nednguyen@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
What's the side-effect of this change on the GPU tests which haven't been cut over to the run_gpu_integration_test_as_googletest.py wrapper script (there are still a few)?
On 2016/10/10 18:49:00, Ken Russell wrote: > What's the side-effect of this change on the GPU tests which haven't been cut > over to the run_gpu_integration_test_as_googletest.py wrapper script (there are > still a few)? Answering my own question: I see that your earlier https://codereview.chromium.org/2375663003 cleverly auto-detects the format that the target test outputs. Very nice. LGTM
The CQ bit was unchecked by nednguyen@google.com
The CQ bit was checked by nednguyen@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [testing/script] Switch run_telemetry_as_googletest.py to produce full json results format BUG=649762 ========== to ========== [testing/script] Switch run_telemetry_as_googletest.py to produce full json results format BUG=649762 Committed: https://crrev.com/caa3b797728c9337fcea7d108a087d005fa7f451 Cr-Commit-Position: refs/heads/master@{#424206} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/caa3b797728c9337fcea7d108a087d005fa7f451 Cr-Commit-Position: refs/heads/master@{#424206}
Message was sent while issue was closed.
lgtm
Message was sent while issue was closed.
Looks like this change fails telemetry tests. https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests... WDYT?
Message was sent while issue was closed.
On 2016/10/11 00:55:49, loyso wrote: > Looks like this change fails telemetry tests. > https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests... > WDYT? https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests... also
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2408043002/ by loyso@chromium.org. The reason for reverting is: Speculatively reverting this patch (suggested by findit) to see if it fixes Mac telemetry unit tests. https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests... https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests....
Message was sent while issue was closed.
Confirmed: this CL was the cause.
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2483723003/ by nednguyen@google.com. The reason for reverting is: Mac 10.10 Tests & Mac 10.11 Tests are now swarmed: https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests... https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.11%20Tests.... |