Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Issue 2403913002: [testing/script] Switch run_telemetry_as_googletest.py to produce full json results format (Closed)

Created:
4 years, 2 months ago by nednguyen
Modified:
4 years, 2 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[testing/script] Switch run_telemetry_as_googletest.py to produce full json results format BUG=649762 Committed: https://crrev.com/caa3b797728c9337fcea7d108a087d005fa7f451 Cr-Commit-Position: refs/heads/master@{#424206}

Patch Set 1 #

Patch Set 2 : Update flag type #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -18 lines) Patch
M testing/scripts/run_telemetry_as_googletest.py View 1 2 chunks +3 lines, -18 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
nednguyen
4 years, 2 months ago (2016-10-10 17:39:48 UTC) #2
Ken Russell (switch to Gerrit)
What's the side-effect of this change on the GPU tests which haven't been cut over ...
4 years, 2 months ago (2016-10-10 18:49:00 UTC) #9
Ken Russell (switch to Gerrit)
On 2016/10/10 18:49:00, Ken Russell wrote: > What's the side-effect of this change on the ...
4 years, 2 months ago (2016-10-10 18:54:26 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2403913002/20001
4 years, 2 months ago (2016-10-10 19:12:13 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-10 19:33:45 UTC) #14
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/caa3b797728c9337fcea7d108a087d005fa7f451 Cr-Commit-Position: refs/heads/master@{#424206}
4 years, 2 months ago (2016-10-10 19:36:18 UTC) #16
Dirk Pranke
lgtm
4 years, 2 months ago (2016-10-10 23:41:55 UTC) #17
loyso (OOO)
Looks like this change fails telemetry tests. https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/8276 WDYT?
4 years, 2 months ago (2016-10-11 00:55:49 UTC) #18
loyso (OOO)
On 2016/10/11 00:55:49, loyso wrote: > Looks like this change fails telemetry tests. > https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests/builds/8276 ...
4 years, 2 months ago (2016-10-11 00:57:09 UTC) #19
loyso (OOO)
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2408043002/ by loyso@chromium.org. ...
4 years, 2 months ago (2016-10-11 02:04:07 UTC) #20
loyso (OOO)
Confirmed: this CL was the cause.
4 years, 2 months ago (2016-10-11 06:18:13 UTC) #21
nednguyen
4 years, 1 month ago (2016-11-07 15:06:24 UTC) #22
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2483723003/ by nednguyen@google.com.

The reason for reverting is: Mac 10.10 Tests & Mac 10.11 Tests are now swarmed:
https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests...

https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.11%20Tests....

Powered by Google App Engine
This is Rietveld 408576698