Only treat lookup-slot-calls going through 'with' special

Only treat lookup-slot-calls going through 'with' special

This replaces LOOKUP_SLOT_CALL with WITH_CALL, and relies on regular lookup-slot handling in variable load to support other lookup slots (variables resolved in the context of sloppy eval). This allows optimizations for such variable loads to kick in for calls as well. We only need special handling for function calls in the context of with, since it changes the receiver of the call from undefined/global to the with-object.

This currently doesn't yet make it work for the direct eval call itself, since the POSSIBLY_EVAL_CALL flag is also used to deal with direct eval later.

BUG=

Committed: https://crrev.com/733af7eb1af0a57f261c7bef9c38a08afb9b64c8
Cr-Commit-Position: refs/heads/master@{#40962}

[Toon Verwaest, 2016-11-08 15:27:56]

verwaest@chromium.org changed reviewers:
+ mstarzinger@chromium.org, rmcilroy@chromium.org

[Toon Verwaest, 2016-11-08 15:27:57]

ptal

[Toon Verwaest, 2016-11-08 15:28:09]

The CQ bit was checked by verwaest@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-08 15:28:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 15:55:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 15:55:32]

Dry run: This issue passed the CQ dry run.

[rmcilroy, 2016-11-08 16:21:33]

Looks reasonable to me, but I don't know this code so I'll leave Michi to
comment.

[Toon Verwaest, 2016-11-10 12:48:19]

ping

[Michael Starzinger, 2016-11-10 15:20:27]

LGTM from my end.

https://codereview.chromium.org/2480253006/diff/20001/src/ast/ast.cc
File src/ast/ast.cc (right):

https://codereview.chromium.org/2480253006/diff/20001/src/ast/ast.cc#newcode904
src/ast/ast.cc:904: return proxy->var()->mode() == DYNAMIC ? WITH_CALL :
OTHER_CALL;
Can we add a brief comment here saying that "DYNAMIC_LOCAL" and "DYNAMIC_GLOBAL"
will never be used to model a call scoped inside a with-scope?

[Toon Verwaest, 2016-11-14 10:02:38]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-11-14 10:02:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2480253006/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-11-14 10:02:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 10:16:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-14 10:16:58]

Try jobs failed on following builders:
  v8_linux64_gyp_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng/build...)
  v8_linux64_gyp_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_gyp_rel_ng_trigg...)

[Toon Verwaest, 2016-11-14 11:57:53]

The CQ bit was checked by verwaest@chromium.org

[Toon Verwaest, 2016-11-14 11:57:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
mstarzinger@chromium.org
Link to the patchset: https://codereview.chromium.org/2480253006/#ps80001
(title: "rebaseline expectations")

[commit-bot: I haz the power, 2016-11-14 11:58:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-14 12:23:39]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-17 22:32:25]

Description was changed from

==========
Only treat lookup-slot-calls going through 'with' special

This replaces LOOKUP_SLOT_CALL with WITH_CALL, and relies on regular lookup-slot
handling in variable load to support other lookup slots (variables resolved in
the context of sloppy eval). This allows optimizations for such variable loads
to kick in for calls as well. We only need special handling for function calls
in the context of with, since it changes the receiver of the call from
undefined/global to the with-object.

This currently doesn't yet make it work for the direct eval call itself, since
the POSSIBLY_EVAL_CALL flag is also used to deal with direct eval later.

BUG=
==========

to

==========
Only treat lookup-slot-calls going through 'with' special

This replaces LOOKUP_SLOT_CALL with WITH_CALL, and relies on regular lookup-slot
handling in variable load to support other lookup slots (variables resolved in
the context of sloppy eval). This allows optimizations for such variable loads
to kick in for calls as well. We only need special handling for function calls
in the context of with, since it changes the receiver of the call from
undefined/global to the with-object.

This currently doesn't yet make it work for the direct eval call itself, since
the POSSIBLY_EVAL_CALL flag is also used to deal with direct eval later.

BUG=

Committed: https://crrev.com/733af7eb1af0a57f261c7bef9c38a08afb9b64c8
Cr-Commit-Position: refs/heads/master@{#40962}
==========

[commit-bot: I haz the power, 2016-11-17 22:32:28]

Patchset 5 (id:??) landed as
https://crrev.com/733af7eb1af0a57f261c7bef9c38a08afb9b64c8
Cr-Commit-Position: refs/heads/master@{#40962}