Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: src/full-codegen/full-codegen.cc

Issue 2480253006: Only treat lookup-slot-calls going through 'with' special (Closed)
Patch Set: rebaseline expectations Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/interpreter/bytecode-generator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/full-codegen/full-codegen.h" 5 #include "src/full-codegen/full-codegen.h"
6 6
7 #include "src/ast/ast-numbering.h" 7 #include "src/ast/ast-numbering.h"
8 #include "src/ast/ast.h" 8 #include "src/ast/ast.h"
9 #include "src/ast/prettyprinter.h" 9 #include "src/ast/prettyprinter.h"
10 #include "src/ast/scopes.h" 10 #include "src/ast/scopes.h"
(...skipping 1655 matching lines...) Expand 10 before | Expand all | Expand 10 after
1666 Expression* callee = expr->expression(); 1666 Expression* callee = expr->expression();
1667 Call::CallType call_type = expr->GetCallType(); 1667 Call::CallType call_type = expr->GetCallType();
1668 1668
1669 switch (call_type) { 1669 switch (call_type) {
1670 case Call::POSSIBLY_EVAL_CALL: 1670 case Call::POSSIBLY_EVAL_CALL:
1671 EmitPossiblyEvalCall(expr); 1671 EmitPossiblyEvalCall(expr);
1672 break; 1672 break;
1673 case Call::GLOBAL_CALL: 1673 case Call::GLOBAL_CALL:
1674 EmitCallWithLoadIC(expr); 1674 EmitCallWithLoadIC(expr);
1675 break; 1675 break;
1676 case Call::LOOKUP_SLOT_CALL: 1676 case Call::WITH_CALL:
1677 // Call to a lookup slot (dynamically introduced variable). 1677 // Call to a lookup slot looked up through a with scope.
1678 PushCalleeAndWithBaseObject(expr); 1678 PushCalleeAndWithBaseObject(expr);
1679 EmitCall(expr); 1679 EmitCall(expr);
1680 break; 1680 break;
1681 case Call::NAMED_PROPERTY_CALL: { 1681 case Call::NAMED_PROPERTY_CALL: {
1682 Property* property = callee->AsProperty(); 1682 Property* property = callee->AsProperty();
1683 VisitForStackValue(property->obj()); 1683 VisitForStackValue(property->obj());
1684 EmitCallWithLoadIC(expr); 1684 EmitCallWithLoadIC(expr);
1685 break; 1685 break;
1686 } 1686 }
1687 case Call::KEYED_PROPERTY_CALL: { 1687 case Call::KEYED_PROPERTY_CALL: {
(...skipping 302 matching lines...) Expand 10 before | Expand all | Expand 10 after
1990 return info_->has_simple_parameters(); 1990 return info_->has_simple_parameters();
1991 } 1991 }
1992 1992
1993 FunctionLiteral* FullCodeGenerator::literal() const { return info_->literal(); } 1993 FunctionLiteral* FullCodeGenerator::literal() const { return info_->literal(); }
1994 1994
1995 #undef __ 1995 #undef __
1996 1996
1997 1997
1998 } // namespace internal 1998 } // namespace internal
1999 } // namespace v8 1999 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/ast-graph-builder.cc ('k') | src/interpreter/bytecode-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698