src/ast/ast.cc - Issue 2480253006: Only treat lookup-slot-calls going through 'with' special

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ast/ast.cc

Issue 2480253006: Only treat lookup-slot-calls going through 'with' special (Closed)

Patch Set: rebaseline expectations Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ast/ast.cc

diff --git a/src/ast/ast.cc b/src/ast/ast.cc

index 7fa115524d1a852f8eb70b71fc631d4711971270..698d46a1aa4738cbf10f36cb46a14d7d854db3c7 100644

--- a/src/ast/ast.cc

+++ b/src/ast/ast.cc

@@ -901,7 +901,9 @@ Call::CallType Call::GetCallType() const {

} else if (proxy->var()->IsUnallocated()) {

return GLOBAL_CALL;

} else if (proxy->var()->IsLookupSlot()) {

- return LOOKUP_SLOT_CALL;

+ // Calls going through 'with' always use DYNAMIC rather than DYNAMIC_LOCAL

+ // or DYNAMIC_GLOBAL.

+ return proxy->var()->mode() == DYNAMIC ? WITH_CALL : OTHER_CALL;

}

« no previous file with comments | « src/ast/ast.h ('k') | src/compiler/ast-graph-builder.cc » ('j') | no next file with comments »