Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: sync/api/sync_data.cc

Issue 247983002: Keep track of which attachments are referenced by which sync entries. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix "copy yourself bug". Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/sync_driver/generic_change_processor.cc ('K') | « sync/api/attachments/fake_attachment_service.cc ('k') | sync/engine/get_commit_ids.cc » ('j') | sync/syncable/directory.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/api/sync_data.cc
diff --git a/sync/api/sync_data.cc b/sync/api/sync_data.cc
index fa48ea5edc18a89a1c20d15325e9e58bcee727b6..225c1407c89ed7b0cdd692dd96dbeeba946d55c0 100644
--- a/sync/api/sync_data.cc
+++ b/sync/api/sync_data.cc
@@ -113,9 +113,6 @@ SyncData SyncData::CreateLocalDataWithAttachments(
attachments.end(),
RepeatedFieldBackInserter(entity.mutable_attachment_id()),
AttachmentToProto);
- // TODO(maniscalco): Actually pass the attachments to the ctor and make them
- // available to the AttachmentService once this SyncData gets passed into
- // GenericChangeProcesso::ProcessSyncChanges (bug 354530).
AttachmentList copy_of_attachments(attachments);
return SyncData(kInvalidId,
&entity,
« components/sync_driver/generic_change_processor.cc ('K') | « sync/api/attachments/fake_attachment_service.cc ('k') | sync/engine/get_commit_ids.cc » ('j') | sync/syncable/directory.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698