sync/api/attachments/fake_attachment_service.cc - Issue 247983002: Keep track of which attachments are referenced by which sync entries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/api/attachments/fake_attachment_service.cc

Issue 247983002: Keep track of which attachments are referenced by which sync entries. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix "copy yourself bug". Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/api/attachments/fake_attachment_service.cc

diff --git a/sync/api/attachments/fake_attachment_service.cc b/sync/api/attachments/fake_attachment_service.cc

index 8e9e867f9ada7acde10079892cfde7cf2ff3a298..f6fed46f358a870b908031565e4ceb90a191a4e0 100644

--- a/sync/api/attachments/fake_attachment_service.cc

+++ b/sync/api/attachments/fake_attachment_service.cc

@@ -53,7 +53,8 @@ void FakeAttachmentService::DropAttachments(

callback));

}

-void FakeAttachmentService::OnSyncDataAdd(const SyncData& sync_data) {

+void FakeAttachmentService::StoreAttachments(const AttachmentList& attachment,

+ const StoreCallback& callback) {

DCHECK(CalledOnValidThread());

// TODO(maniscalco): Ensure the linked attachments get persisted in local

// storage and schedule them for upload to the server (bug 356351).