Keep track of which attachments are referenced by which sync entries.

sync/api/sync_data.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "sync/api/sync_data.h"
 
 #include <ostream>
 
 #include "base/json/json_writer.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 95 matching lines @@
     const sync_pb::EntitySpecifics& specifics,
     const AttachmentList& attachments) {
   sync_pb::SyncEntity entity;
   entity.set_client_defined_unique_tag(sync_tag);
   entity.set_non_unique_name(non_unique_title);
   entity.mutable_specifics()->CopyFrom(specifics);
   std::transform(attachments.begin(),
                  attachments.end(),
                  RepeatedFieldBackInserter(entity.mutable_attachment_id()),
                  AttachmentToProto);
-  // TODO(maniscalco): Actually pass the attachments to the ctor and make them
-  // available to the AttachmentService once this SyncData gets passed into
-  // GenericChangeProcesso::ProcessSyncChanges (bug 354530).
   AttachmentList copy_of_attachments(attachments);
   return SyncData(kInvalidId,
                   &entity,
                   &copy_of_attachments,
                   base::Time(),
                   AttachmentServiceProxy());
 }
 
 // Static.
 SyncData SyncData::CreateRemoteData(
@@ skipping 105 matching lines @@
   attachment_service_.GetOrDownloadAttachments(attachment_ids, callback);
 }
 
 void SyncDataRemote::DropAttachments(
     const AttachmentIdList& attachment_ids,
     const AttachmentService::DropCallback& callback) {
   attachment_service_.DropAttachments(attachment_ids, callback);
 }
 
 }  // namespace syncer