Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2479723003: Mac: Fix flickering while entering/leaving fullscreen low power video (Closed)

Created:
4 years, 1 month ago by ccameron
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Mac: Fix flickering while entering/leaving fullscreen low power video Change the low power transition to be 3-state. The states are - not in FSLP mode, FSLP window is hidden - warming up FSLP mode, FSLP window is visible and in the fullscreen state, but is behind the main window - in FSLP mode. the FLSP window is in front of the main window From my experiments, adding up this "warming up" state, makes it so that the flahses when entering FSLP mode go away. When exiting FSLP mode, it used to be that we would call -[AVSampleBufferDisplayLayer flushAndRemoveImage] immediately, since it never caused any issues. I was able to see some black flashes on Sierra. If I change it so that we wait for 15 frames to do this, then the flashes go away. BUG=661691 Review-Url: https://codereview.chromium.org/2468063004 Cr-Commit-Position: refs/heads/master@{#429515} (cherry picked from commit d8ca506c965aa6331149055e421c9d2e9c2b14ab)

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -55 lines) Patch
M chrome/browser/ui/cocoa/fullscreen_low_power_coordinator.h View 3 chunks +17 lines, -6 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_low_power_coordinator.mm View 4 chunks +71 lines, -31 lines 0 comments Download
M chrome/browser/ui/cocoa/fullscreen_low_power_coordinator_unittest.mm View 8 chunks +17 lines, -10 lines 0 comments Download
M ui/accelerated_widget_mac/ca_layer_tree_coordinator.h View 1 chunk +4 lines, -1 line 0 comments Download
M ui/accelerated_widget_mac/ca_layer_tree_coordinator.mm View 2 chunks +12 lines, -7 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
ccameron
4 years, 1 month ago (2016-11-04 22:05:38 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 (id:1) to pending queue manually as
3f61bd2bee9f80e8b5f31a7b006916a94da11178.

Powered by Google App Engine
This is Rietveld 408576698