Mac: Fix flickering while entering/leaving fullscreen low power video

Mac: Fix flickering while entering/leaving fullscreen low power video

Change the low power transition to be 3-state. The states are
- not in FSLP mode, FSLP window is hidden
- warming up FSLP mode, FSLP window is visible and in the fullscreen
  state, but is behind the main window
- in FSLP mode. the FLSP window is in front of the main window

From my experiments, adding up this "warming up" state, makes it so
that the flahses when entering FSLP mode go away.

When exiting FSLP mode, it used to be that we would call
-[AVSampleBufferDisplayLayer flushAndRemoveImage] immediately, since
it never caused any issues. I was able to see some black flashes on
Sierra. If I change it so that we wait for 15 frames to do this, then
the flashes go away.

BUG=661691
Committed: https://crrev.com/d8ca506c965aa6331149055e421c9d2e9c2b14ab
Cr-Commit-Position: refs/heads/master@{#429515}

[ccameron, 2016-11-03 01:23:58]

ccameron@chromium.org changed reviewers:
+ erikchen@chromium.org, spqchan@chromium.org

[ccameron, 2016-11-03 01:23:59]

This fixes some of the FSLP transition issues that we have.

Not all of the issues -- we still see the background incorrect when leaving
fullscreen -- added a TODO for that. Also of note is that FSLP buys us nothing
on Sierra, so I'm just going to disable it.

[ccameron, 2016-11-03 01:24:20]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 01:24:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[erikchen, 2016-11-03 01:33:41]

On 2016/11/03 01:23:59, ccameron wrote:
> This fixes some of the FSLP transition issues that we have.
> 
> Not all of the issues -- we still see the background incorrect when leaving
> fullscreen -- added a TODO for that.
Is there a bug tracking that?

> Also of note is that FSLP buys us nothing
> on Sierra, so I'm just going to disable it.

lgtm

[erikchen, 2016-11-03 01:34:08]

On 2016/11/03 01:33:41, erikchen wrote:
> On 2016/11/03 01:23:59, ccameron wrote:
> > This fixes some of the FSLP transition issues that we have.
> > 
> > Not all of the issues -- we still see the background incorrect when leaving
> > fullscreen -- added a TODO for that.
> Is there a bug tracking that?
> 
https://bugs.chromium.org/p/chromium/issues/detail?id=644133

> > Also of note is that FSLP buys us nothing
> > on Sierra, so I'm just going to disable it.
> 
> lgtm

[commit-bot: I haz the power, 2016-11-03 01:48:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 01:48:29]

Dry run: This issue passed the CQ dry run.

[ccameron, 2016-11-03 02:05:26]

Thanks!

/facepalm about the Sierra false alarm...

[ccameron, 2016-11-03 02:08:39]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2016-11-03 02:09:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 02:15:30]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-11-03 02:18:09]

Description was changed from

==========
Mac: Fix flickering while entering/leaving fullscreen low power video

Change the low power transition to be 3-state. The states are
- not in FSLP mode, FSLP window is hidden
- warming up FSLP mode, FSLP window is visible and in the fullscreen
  state, but is behind the main window
- in FSLP mode. the FLSP window is in front of the main window

From my experiments, adding up this "warming up" state, makes it so
that the flahses when entering FSLP mode go away.

When exiting FSLP mode, it used to be that we would call
-[AVSampleBufferDisplayLayer flushAndRemoveImage] immediately, since
it never caused any issues. I was able to see some black flashes on
Sierra. If I change it so that we wait for 15 frames to do this, then
the flashes go away.

BUG=661691
==========

to

==========
Mac: Fix flickering while entering/leaving fullscreen low power video

Change the low power transition to be 3-state. The states are
- not in FSLP mode, FSLP window is hidden
- warming up FSLP mode, FSLP window is visible and in the fullscreen
  state, but is behind the main window
- in FSLP mode. the FLSP window is in front of the main window

From my experiments, adding up this "warming up" state, makes it so
that the flahses when entering FSLP mode go away.

When exiting FSLP mode, it used to be that we would call
-[AVSampleBufferDisplayLayer flushAndRemoveImage] immediately, since
it never caused any issues. I was able to see some black flashes on
Sierra. If I change it so that we wait for 15 frames to do this, then
the flashes go away.

BUG=661691

Committed: https://crrev.com/d8ca506c965aa6331149055e421c9d2e9c2b14ab
Cr-Commit-Position: refs/heads/master@{#429515}
==========

[commit-bot: I haz the power, 2016-11-03 02:18:10]

Patchset 1 (id:??) landed as
https://crrev.com/d8ca506c965aa6331149055e421c9d2e9c2b14ab
Cr-Commit-Position: refs/heads/master@{#429515}

[erikchen, 2016-11-03 18:20:01]

https://codereview.chromium.org/2468063004/diff/1/chrome/browser/ui/cocoa/ful...
File chrome/browser/ui/cocoa/fullscreen_low_power_coordinator.mm (right):

https://codereview.chromium.org/2468063004/diff/1/chrome/browser/ui/cocoa/ful...
chrome/browser/ui/cocoa/fullscreen_low_power_coordinator.mm:95: // crashes.
system being Chrome or macOS?