Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 2479693002: Roll third_party/inspector_protocol to 2952a8eb5d99fbc194946526b57d67ed52093699 (Closed)

Created:
4 years, 1 month ago by kozy
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Roll third_party/inspector_protocol to 2952a8eb5d99fbc194946526b57d67ed52093699 This roll includes one change: "[inspector_protocol] remove old style domains support" [1] https://codereview.chromium.org/2477823002/ BUG=none R=dgozman@chromium.org Committed: https://crrev.com/cbbd91f5abae82547546ec6520280725bee0ccc6 Cr-Commit-Position: refs/heads/master@{#429821}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -117 lines) Patch
M third_party/inspector_protocol/CodeGenerator.py View 2 chunks +1 line, -6 lines 0 comments Download
M third_party/inspector_protocol/README.chromium View 2 chunks +1 line, -2 lines 0 comments Download
D third_party/inspector_protocol/lib/BackendCallback_h.template View 1 chunk +0 lines, -24 lines 0 comments Download
M third_party/inspector_protocol/lib/ErrorSupport_cpp.template View 1 chunk +2 lines, -11 lines 0 comments Download
M third_party/inspector_protocol/lib/ErrorSupport_h.template View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/inspector_protocol/lib/Forward_h.template View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/inspector_protocol/templates/TypeBuilder_cpp.template View 5 chunks +2 lines, -34 lines 0 comments Download
M third_party/inspector_protocol/templates/TypeBuilder_h.template View 4 chunks +3 lines, -37 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (12 generated)
kozy
Dmitry, please take a look.
4 years, 1 month ago (2016-11-03 22:47:57 UTC) #1
dgozman
lgtm
4 years, 1 month ago (2016-11-03 23:04:29 UTC) #2
commit-bot: I haz the power
This CL has an open dependency (Issue 2468233003 Patch 60001). Please resolve the dependency and ...
4 years, 1 month ago (2016-11-04 03:50:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2479693002/1
4 years, 1 month ago (2016-11-04 07:00:34 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 07:05:47 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 07:08:09 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cbbd91f5abae82547546ec6520280725bee0ccc6
Cr-Commit-Position: refs/heads/master@{#429821}

Powered by Google App Engine
This is Rietveld 408576698