[DevTools] Migrate Accessibility, Log, Worker to new style

[DevTools] Migrate Accessibility, Log, Worker to new style

BUG=none
R=dgozman@chromium.org

Committed: https://crrev.com/243e21f8ae70521109365ec092737c6703c9c0bd
Cr-Commit-Position: refs/heads/master@{#429816}

[kozy, 2016-11-02 21:39:49]

Dmitry, please take a look.

I think that it's last part of domains inside of blink. I'll check it by putting
return True inside new_style(domain) function when all other patches are landed.

[kozy, 2016-11-02 21:46:47]

Description was changed from

==========
[DevTools] Migrate Accessibility and Log to new style

BUG=none
R=dgozman@chromium.org
==========

to

==========
[DevTools] Migrate Accessibility and Log to new style

BUG=none
R=dgozman@chromium.org
==========

[kozy, 2016-11-02 21:46:48]

kozyatinskiy@chromium.org changed reviewers:
+ aboxhall@chromium.org

[dgozman, 2016-11-02 23:04:39]

lgtm

[kozy, 2016-11-03 00:47:32]

Alice, please take a look!

[kozy, 2016-11-03 06:56:04]

Description was changed from

==========
[DevTools] Migrate Accessibility and Log to new style

BUG=none
R=dgozman@chromium.org
==========

to

==========
[DevTools] Migrate Accessibility, Log, Worker to new style

BUG=none
R=dgozman@chromium.org
==========

[kozy, 2016-11-03 06:56:41]

Dmitry, please take another look. I migrated worker agent - it's the last not
migrated domain :)

[kozy, 2016-11-03 16:44:06]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 16:44:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2016-11-03 17:12:31]

The CQ bit was unchecked by kozyatinskiy@chromium.org

[kozy, 2016-11-03 17:13:05]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 17:13:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 20:26:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 20:26:34]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[kozy, 2016-11-03 21:16:06]

The CQ bit was checked by kozyatinskiy@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 21:16:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-11-03 21:26:24]

Still lgtm

https://codereview.chromium.org/2468233003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h (right):

https://codereview.chromium.org/2468233003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h:89:
this->disable();
Response disable() override { return Response::OK(); }

And then just disable().

[kozy, 2016-11-03 22:18:27]

All done, thanks.

https://codereview.chromium.org/2468233003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h (right):

https://codereview.chromium.org/2468233003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorBaseAgent.h:89:
this->disable();
On 2016/11/03 21:26:24, dgozman wrote:
> Response disable() override { return Response::OK(); }
> 
> And then just disable().

Done.

[kozy, 2016-11-03 22:18:48]

The CQ bit was checked by kozyatinskiy@chromium.org

[kozy, 2016-11-03 22:18:48]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2468233003/#ps60001
(title: "addressed comments")

[commit-bot: I haz the power, 2016-11-03 22:19:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[kozy, 2016-11-04 01:35:02]

The CQ bit was unchecked by kozyatinskiy@chromium.org

[kozy, 2016-11-04 01:35:04]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-11-04 01:35:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 04:00:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 04:00:07]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[kozy, 2016-11-04 05:24:18]

The CQ bit was checked by kozyatinskiy@chromium.org

[commit-bot: I haz the power, 2016-11-04 05:24:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 06:51:33]

Description was changed from

==========
[DevTools] Migrate Accessibility, Log, Worker to new style

BUG=none
R=dgozman@chromium.org
==========

to

==========
[DevTools] Migrate Accessibility, Log, Worker to new style

BUG=none
R=dgozman@chromium.org
==========

[commit-bot: I haz the power, 2016-11-04 06:51:35]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-04 06:53:47]

Description was changed from

==========
[DevTools] Migrate Accessibility, Log, Worker to new style

BUG=none
R=dgozman@chromium.org
==========

to

==========
[DevTools] Migrate Accessibility, Log, Worker to new style

BUG=none
R=dgozman@chromium.org

Committed: https://crrev.com/243e21f8ae70521109365ec092737c6703c9c0bd
Cr-Commit-Position: refs/heads/master@{#429816}
==========

[commit-bot: I haz the power, 2016-11-04 06:53:49]

Patchset 4 (id:??) landed as
https://crrev.com/243e21f8ae70521109365ec092737c6703c9c0bd
Cr-Commit-Position: refs/heads/master@{#429816}