Fix test failure expectations and update status files.

Fix test failure expectations and update status files.

R=hausner@google.com

Committed: https://code.google.com/p/dart/source/detail?r=27976

[Ivan Posva, 2013-09-26 20:58:53]

Generally looks good to me.

-Ivan

https://codereview.chromium.org/24789003/diff/1/tests/language/bad_constructo...
File tests/language/bad_constructor_test.dart (right):

https://codereview.chromium.org/24789003/diff/1/tests/language/bad_constructo...
tests/language/bad_constructor_test.dart:8: static A() { }  /// 00: compile-time
error
Shouldn't

class A {
  static A();
}

also be an error?

https://codereview.chromium.org/24789003/diff/1/tests/language/bad_constructo...
tests/language/bad_constructor_test.dart:18: A.q() { }   /// 05: runtime error
In what circumstance do we get a runtime error here and why? Please add a
comment to that effect.

[hausner, 2013-09-26 21:36:05]

Essentially the same questions as Ivan has. Otherwise lgtm.

https://codereview.chromium.org/24789003/diff/4001/tests/language/bad_constru...
File tests/language/bad_constructor_test.dart (right):

https://codereview.chromium.org/24789003/diff/4001/tests/language/bad_constru...
tests/language/bad_constructor_test.dart:8: static A() { }  /// 00: compile-time
error
Why the change to { }?

https://codereview.chromium.org/24789003/diff/4001/tests/language/bad_constru...
tests/language/bad_constructor_test.dart:18: A.q() { }   /// 05: runtime error
Why is this a runtime error? Can you add a comment?

https://codereview.chromium.org/24789003/diff/4001/tests/language/bad_constru...
tests/language/bad_constructor_test.dart:20: A.foo() : m = 0 { }  /// 06:
compile-time error
Why the change to empty body? A semicolon means empty body as well.

https://codereview.chromium.org/24789003/diff/4001/tests/lib/mirrors/library_...
File tests/lib/mirrors/library_metadata2_test.dart (right):

https://codereview.chromium.org/24789003/diff/4001/tests/lib/mirrors/library_...
tests/lib/mirrors/library_metadata2_test.dart:9: import
'library_metadata2_lib2.dart'; /// 01: runtime error
Would be nice to have a comment why we expect a runtime error.

[regis, 2013-09-26 22:12:26]

Thanks, PTAL.

-- Regis

https://codereview.chromium.org/24789003/diff/1/tests/language/bad_constructo...
File tests/language/bad_constructor_test.dart (right):

https://codereview.chromium.org/24789003/diff/1/tests/language/bad_constructo...
tests/language/bad_constructor_test.dart:8: static A() { }  /// 00: compile-time
error
On 2013/09/26 20:58:53, Ivan Posva wrote:
> Shouldn't
> 
> class A {
>   static A();
> }
> 
> also be an error?

Yes, it is the same. I just find the syntax with the semicolon harder to read.
Reverted here and at other places.

https://codereview.chromium.org/24789003/diff/1/tests/language/bad_constructo...
tests/language/bad_constructor_test.dart:18: A.q() { }   /// 05: runtime error
On 2013/09/26 20:58:53, Ivan Posva wrote:
> In what circumstance do we get a runtime error here and why? Please add a
> comment to that effect.

main calls new A() instead of new A.q().
Comment added.
BTW, I missed a failure in Dart2js here. Bug filed and status updated.

https://codereview.chromium.org/24789003/diff/4001/tests/language/bad_constru...
File tests/language/bad_constructor_test.dart (right):

https://codereview.chromium.org/24789003/diff/4001/tests/language/bad_constru...
tests/language/bad_constructor_test.dart:8: static A() { }  /// 00: compile-time
error
On 2013/09/26 21:36:05, hausner wrote:
> Why the change to { }?

Already replied to Ivan. Anyway, reverted here and elsewhere.

https://codereview.chromium.org/24789003/diff/4001/tests/language/bad_constru...
tests/language/bad_constructor_test.dart:18: A.q() { }   /// 05: runtime error
On 2013/09/26 21:36:05, hausner wrote:
> Why is this a runtime error? Can you add a comment?

Done.

https://codereview.chromium.org/24789003/diff/4001/tests/language/bad_constru...
tests/language/bad_constructor_test.dart:20: A.foo() : m = 0 { }  /// 06:
compile-time error
On 2013/09/26 21:36:05, hausner wrote:
> Why the change to empty body? A semicolon means empty body as well.

Done.

https://codereview.chromium.org/24789003/diff/4001/tests/lib/mirrors/library_...
File tests/lib/mirrors/library_metadata2_test.dart (right):

https://codereview.chromium.org/24789003/diff/4001/tests/lib/mirrors/library_...
tests/lib/mirrors/library_metadata2_test.dart:9: import
'library_metadata2_lib2.dart'; /// 01: runtime error
On 2013/09/26 21:36:05, hausner wrote:
> Would be nice to have a comment why we expect a runtime error.

Done.

[hausner, 2013-09-26 22:16:34]

lgtm

[regis, 2013-09-26 22:19:08]

Committed patchset #3 manually as r27976 (presubmit successful).

[ahe, 2013-10-08 14:24:30]

https://codereview.chromium.org/24789003/diff/11001/tests/lib/mirrors/library...
File tests/lib/mirrors/library_metadata2_test.dart (right):

https://codereview.chromium.org/24789003/diff/11001/tests/lib/mirrors/library...
tests/lib/mirrors/library_metadata2_test.dart:14: // runtime error here.
Please revert this change, it is not correct.

Also, please don't just change tests without asking the original authors of a
test for input. Chances are you make mistakes when you do so.

The specification says:

"Metadata consists of a series of annotations, each of which begin with the
character @, followed a constant expression that starts with an identifier."
(https://www.dartlang.org/docs/spec/latest/dart-language-specification.html#h....)

"It is a compile-time error if evaluation of a compile-time constant would raise
an exception."
(https://www.dartlang.org/docs/spec/latest/dart-language-specification.html#h....)

[Ivan Posva, 2013-10-09 06:57:01]

https://codereview.chromium.org/24789003/diff/11001/tests/lib/mirrors/library...
File tests/lib/mirrors/library_metadata2_test.dart (right):

https://codereview.chromium.org/24789003/diff/11001/tests/lib/mirrors/library...
tests/lib/mirrors/library_metadata2_test.dart:14: // runtime error here.
On 2013/10/08 14:24:30, ahe wrote:
> Please revert this change, it is not correct.
> 
> Also, please don't just change tests without asking the original authors of a
> test for input. Chances are you make mistakes when you do so.
> 
> The specification says:
> 
> "Metadata consists of a series of annotations, each of which begin with the
> character @, followed a constant expression that starts with an identifier."
>
(https://www.dartlang.org/docs/spec/latest/dart-language-specification.html#h....)
> 
> "It is a compile-time error if evaluation of a compile-time constant would
raise
> an exception."
>
(https://www.dartlang.org/docs/spec/latest/dart-language-specification.html#h....)

We consulted with Gilad on this before changing the test. Please discuss this
with him. But as far as we could tell this leads to a compile-time error during
the access of the metadata which is intercepted by the mirror system and
communicated to the user as a runtime error.

Thanks,
-Ivan