Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2478853002: Roll third_party/inspector_protocol to ebda02bf94a742a2e26e4f818df1fc77517ac44c (Closed)

Created:
4 years, 1 month ago by kozy
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
v8-reviews_googlegroups.com, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Roll third_party/inspector_protocol to ebda02bf94a742a2e26e4f818df1fc77517ac44c This roll includes: - [inspector_protocol] remove old style domains support - Add missing virtual destructor to backend callbacks. [2] [1] https://codereview.chromium.org/2479693002/ [2] https://codereview.chromium.org/2473393002/ BUG=none R=dgozman@chromium.org Committed: https://crrev.com/c7eb62263548090af52dbd0e12a31b4a3c63da47 Cr-Commit-Position: refs/heads/master@{#40784}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -93 lines) Patch
M third_party/inspector_protocol/CodeGenerator.py View 2 chunks +1 line, -6 lines 0 comments Download
M third_party/inspector_protocol/README.v8 View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/inspector_protocol/lib/ErrorSupport_cpp.template View 1 chunk +2 lines, -11 lines 0 comments Download
M third_party/inspector_protocol/lib/ErrorSupport_h.template View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/inspector_protocol/lib/Forward_h.template View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/inspector_protocol/templates/TypeBuilder_cpp.template View 5 chunks +2 lines, -34 lines 0 comments Download
M third_party/inspector_protocol/templates/TypeBuilder_h.template View 4 chunks +4 lines, -37 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 19 (14 generated)
kozy
Dmitry, please take a look.
4 years, 1 month ago (2016-11-04 15:11:47 UTC) #1
dgozman
rs lgtm
4 years, 1 month ago (2016-11-04 22:36:52 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2478853002/1
4 years, 1 month ago (2016-11-04 22:44:54 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-04 22:47:00 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:23:51 UTC) #19
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c7eb62263548090af52dbd0e12a31b4a3c63da47
Cr-Commit-Position: refs/heads/master@{#40784}

Powered by Google App Engine
This is Rietveld 408576698