Chromium Code Reviews Chromium Code Reviews
Issue 2478483003:
Ignore the percentage value to calculate the logical height of input control
| Index: third_party/WebKit/LayoutTests/fast/forms/input-height.html |
| diff --git a/third_party/WebKit/LayoutTests/fast/forms/input-height.html b/third_party/WebKit/LayoutTests/fast/forms/input-height.html |
| new file mode 100644 |
| index 0000000000000000000000000000000000000000..0a475901391a2575e3a48e1fc0a949d0aa23d5d1 |
| --- /dev/null |
| +++ b/third_party/WebKit/LayoutTests/fast/forms/input-height.html |
| @@ -0,0 +1,60 @@ |
| +<!DOCTYPE html> |
|
tkent
2017/01/19 02:13:03
I recommend to make this a reference test, not a p
joone
2017/01/23 01:07:08
Done.
|
| +<html> |
| +<head> |
| +<style type="text/css"> |
| +:root { |
| + --input-height: 100%; |
| +} |
| + |
| +body { |
| + background-color: gray; |
| +} |
| + |
| +#component-search { |
| + background-color: blue; |
| + height: 32px; |
| + width: 175px; |
| +} |
| + #component-search input.query { |
| + background: yellow; |
| + border: none; |
| + float: left; |
| + height: var(--input-height); |
| + line-height: 24px; |
| + padding: 0 0 0 5px; |
| + width: 143px; |
| +} |
| +</style> |
| + |
| +<title>input caret size by cubix</title> |
|
tkent
2017/01/19 02:13:03
Now caret size is not a problem.
joone
2017/01/23 01:07:08
Done.
|
| +</head> |
| + |
| +<body> |
| + <div id="component-search" class="header-component"> |
| + <form action="http://cbslocal.com/search/" class="search"> |
| + <input type="text" class="query" name="q" id="s" size="31" placeholder="Search" autocomplete="off" style="color: black;"> |
| + <input type="reset" class="reset" value="Reset"> |
| + <input type="submit" class="submit" value="Search"> |
| + </form> |
| + </div> |
| + <br><br> |
| + <div id="component-search" class="header-component"> |
|
tkent
2017/01/19 02:13:03
ID attribute value 'component-search' conflicts wi
joone
2017/01/23 01:07:08
Done.
|
| + <form action="http://cbslocal.com/search/" class="search"> |
| + <input type="text" class="query" name="q" id="s" size="31" placeholder="Search" autocomplete="off" style="color: black; height: 30%"> |
|
tkent
2017/01/19 02:13:03
ID attribute value 's' conflicts with other elemen
joone
2017/01/23 01:07:08
Done.
|
| + <input type="reset" class="reset" value="Reset"> |
| + <input type="submit" class="submit" value="Search"> |
| + </form> |
| + </div> |
| + <br> |
| + <div id="component-search" class="header-component"> |
| + <form action="http://cbslocal.com/search/" class="search"> |
| + <input type="text" class="query" name="q" id="s" size="31" placeholder="Search" autocomplete="off" style="color: black; height: 9.6px"> |
| + <input type="reset" class="reset" value="Reset"> |
| + <input type="submit" class="submit" value="Search"> |
| + </form> |
| + </div> |
| + |
| +</body> |
| +</html> |
| + |
|
tkent
2017/01/19 02:13:03
unnecessary blank lines.
joone
2017/01/23 01:07:08
Done.
|
| + |
