Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(978)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTextControl.cpp

Issue 2478483003: Ignore the percentage value to calculate the logical height of input control
Patch Set: ignore the percentage height Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/LayoutTests/fast/forms/input-height.html ('K') | « third_party/WebKit/LayoutTests/platform/linux/fast/forms/input-height-expected.png ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/layout/LayoutTextControl.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutTextControl.cpp b/third_party/WebKit/Source/core/layout/LayoutTextControl.cpp
index 29f941b8cf885f87093076f0960296b85ecc048a..9673d0eb7f1ec7b44d42082b575a1012ddb6e66d 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTextControl.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutTextControl.cpp
@@ -121,8 +121,7 @@ void LayoutTextControl::computeLogicalHeight(
LayoutUnit nonContentHeight = innerEditorBox->borderAndPaddingHeight() +
innerEditorBox->marginHeight();
logicalHeight = computeControlLogicalHeight(
- innerEditorBox->lineHeight(true, HorizontalLine,
- PositionOfInteriorLineBoxes),
+ this->lineHeight(true, HorizontalLine, PositionOfInteriorLineBoxes),
tkent 2017/01/19 02:13:03 nit: |this->| is unnecessary.
nonContentHeight);
// We are able to have a horizontal scrollbar if the overflow style is
« third_party/WebKit/LayoutTests/fast/forms/input-height.html ('K') | « third_party/WebKit/LayoutTests/platform/linux/fast/forms/input-height-expected.png ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698