third_party/WebKit/LayoutTests/fast/forms/input-height.html - Issue 2478483003: Ignore the percentage value to calculate the logical height of input control

Side by Side Diff: third_party/WebKit/LayoutTests/fast/forms/input-height.html

Issue 2478483003: Ignore the percentage value to calculate the logical height of input control

Patch Set: ignore the percentage height Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « third_party/WebKit/LayoutTests/TestExpectations ('k') | third_party/WebKit/LayoutTests/fast/forms/input-height-expected.txt » ('j') | third_party/WebKit/Source/core/layout/LayoutTextControl.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	tkent 2017/01/19 02:13:03 I recommend to make this a reference test, not a p I recommend to make this a reference test, not a pixel test. input-height.html should contain * The second DIV of this version; FORM without height + INPUT with height:30%, and * FORM with height + INPUT with height:30% input-height-expected.html should contain: * The first DIV of this version; FORM without height + INPUT without height * The third DIV of this version; FORM without height + INPUT with height:9.6px joone 2017/01/23 01:07:08 Done. Show quoted text On 2017/01/19 02:13:03, tkent wrote: > I recommend to make this a reference test, not a pixel test. > > input-height.html should contain > * The second DIV of this version; FORM without height + INPUT with height:30%, > and > * FORM with height + INPUT with height:30% > > input-height-expected.html should contain: > * The first DIV of this version; FORM without height + INPUT without height > * The third DIV of this version; FORM without height + INPUT with height:9.6px Done.
	2 <html>

	3 <head>

	4 <style type="text/css">

	5 :root {

	6 --input-height: 100%;

	7 }

	8

	9 body {

	10 background-color: gray;

	11 }

	12

	13 #component-search {

	14 background-color: blue;

	15 height: 32px;

	16 width: 175px;

	17 }

	18 #component-search input.query {

	19 background: yellow;

	20 border: none;

	21 float: left;

	22 height: var(--input-height);

	23 line-height: 24px;

	24 padding: 0 0 0 5px;

	25 width: 143px;

	26 }

	27 </style>

	28

	29 <title>input caret size by cubix</title>
	tkent 2017/01/19 02:13:03 Now caret size is not a problem. Now caret size is not a problem. joone 2017/01/23 01:07:08 Done. Show quoted text On 2017/01/19 02:13:03, tkent wrote: > Now caret size is not a problem. Done.
	30 </head>

	31

	32 <body>

	33 <div id="component-search" class="header-component">

	34 <form action="http://cbslocal.com/search/" class="search">

	35 <input type="text" class="query" name="q" id="s" size="31" placeholder="Sea rch" autocomplete="off" style="color: black;">

	36 <input type="reset" class="reset" value="Reset">

	37 <input type="submit" class="submit" value="Search">

	38 </form>

	39 </div>

	40 <br><br>

	41 <div id="component-search" class="header-component">
	tkent 2017/01/19 02:13:03 ID attribute value 'component-search' conflicts wi ID attribute value 'component-search' conflicts with other elements. joone 2017/01/23 01:07:08 Done. Show quoted text On 2017/01/19 02:13:03, tkent wrote: > ID attribute value 'component-search' conflicts with other elements. Done.
	42 <form action="http://cbslocal.com/search/" class="search">

	43 <input type="text" class="query" name="q" id="s" size="31" placeholder="Sea rch" autocomplete="off" style="color: black; height: 30%">
	tkent 2017/01/19 02:13:03 ID attribute value 's' conflicts with other elemen ID attribute value 's' conflicts with other elements. joone 2017/01/23 01:07:08 Done. Show quoted text On 2017/01/19 02:13:03, tkent wrote: > ID attribute value 's' conflicts with other elements. > Done.
	44 <input type="reset" class="reset" value="Reset">

	45 <input type="submit" class="submit" value="Search">

	46 </form>

	47 </div>

	48 <br>

	49 <div id="component-search" class="header-component">

	50 <form action="http://cbslocal.com/search/" class="search">

	51 <input type="text" class="query" name="q" id="s" size="31" placeholder="Sea rch" autocomplete="off" style="color: black; height: 9.6px">

	52 <input type="reset" class="reset" value="Reset">

	53 <input type="submit" class="submit" value="Search">

	54 </form>

	55 </div>

	56

	57 </body>

	58 </html>

	59
	tkent 2017/01/19 02:13:03 unnecessary blank lines. unnecessary blank lines. joone 2017/01/23 01:07:08 Done. Show quoted text On 2017/01/19 02:13:03, tkent wrote: > unnecessary blank lines. Done.
	60

OLD	NEW