[Offline Pages] Remove a debugging feature and a misleading flag.

[Offline Pages] Remove a debugging feature and a misleading flag.

The flag called "IsBackgroundLoadingEnabled" was being used to gate
a debug feature for saving a linked page as MHTML.  This is no longer
needed with the various testing tools we've built so removing the
misleading flag and the feature itself.

Since the associated string is removed, change the existing string
for NTP to the one approved by UX.

BUG=

Committed: https://crrev.com/daa8ffc109069ede17d1d6c313355011b972ec89
Cr-Commit-Position: refs/heads/master@{#430671}

[dewittj, 2016-11-03 23:42:20]

The CQ bit was checked by dewittj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 23:43:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dewittj, 2016-11-03 23:44:07]

Description was changed from

==========
[Offline Pages] Rename a flag to be much less misleading.

BUG=
==========

to

==========
[Offline Pages] Remove a debugging feature and a misleading flag.

The flag called "IsBackgroundLoadingEnabled" was being used to gate
a debug feature for saving a linked page as MHTML.  This is no longer
needed with the various testing tools we've built so removing the
misleading flag and the feature itself.

BUG=
==========

[dewittj, 2016-11-03 23:44:07]

dewittj@chromium.org changed reviewers:
+ dougarnett@chromium.org, petewil@chromium.org

[dewittj, 2016-11-03 23:45:29]

Description was changed from

==========
[Offline Pages] Remove a debugging feature and a misleading flag.

The flag called "IsBackgroundLoadingEnabled" was being used to gate
a debug feature for saving a linked page as MHTML.  This is no longer
needed with the various testing tools we've built so removing the
misleading flag and the feature itself.

BUG=
==========

to

==========
[Offline Pages] Remove a debugging feature and a misleading flag.

The flag called "IsBackgroundLoadingEnabled" was being used to gate
a debug feature for saving a linked page as MHTML.  This is no longer
needed with the various testing tools we've built so removing the
misleading flag and the feature itself.

Since the associated string is removed, change the existing string
for NTP to the one approved by UX.

BUG=
==========

[dewittj, 2016-11-03 23:45:30]

dewittj@chromium.org changed reviewers:
+ vitaliii@chromium.org

[dewittj, 2016-11-04 00:08:03]

Patchset #3 (id:40001) has been deleted

[dewittj, 2016-11-04 00:09:31]

dewittj@chromium.org changed reviewers:
- vitaliii@chromium.org

[dewittj, 2016-11-04 00:12:42]

PTAL, don't think we need any of this anymore!

[dougarnett, 2016-11-04 00:21:35]

lgtm - thanks Justin!

[Pete Williamson, 2016-11-04 17:05:43]

lgtm

[dewittj, 2016-11-04 17:49:19]

The CQ bit was checked by dewittj@chromium.org

[commit-bot: I haz the power, 2016-11-04 17:49:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 17:59:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 17:59:01]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[dewittj, 2016-11-04 20:03:34]

dewittj@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[dewittj, 2016-11-04 20:03:55]

dfalcantara, PTAL at chrome/android and chrome/browser/android

Thanks!

[gone, 2016-11-04 21:13:11]

lgtm

[dewittj, 2016-11-04 22:53:43]

The CQ bit was checked by dewittj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 22:55:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-05 00:13:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-05 00:13:38]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[dewittj, 2016-11-08 17:17:37]

The CQ bit was checked by dewittj@chromium.org

[dewittj, 2016-11-08 17:17:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
dougarnett@chromium.org, petewil@chromium.org, dfalcantara@chromium.org
Link to the patchset: https://codereview.chromium.org/2477943002/#ps80001
(title: "Rebased.")

[commit-bot: I haz the power, 2016-11-08 17:18:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 18:46:15]

Description was changed from

==========
[Offline Pages] Remove a debugging feature and a misleading flag.

The flag called "IsBackgroundLoadingEnabled" was being used to gate
a debug feature for saving a linked page as MHTML.  This is no longer
needed with the various testing tools we've built so removing the
misleading flag and the feature itself.

Since the associated string is removed, change the existing string
for NTP to the one approved by UX.

BUG=
==========

to

==========
[Offline Pages] Remove a debugging feature and a misleading flag.

The flag called "IsBackgroundLoadingEnabled" was being used to gate
a debug feature for saving a linked page as MHTML.  This is no longer
needed with the various testing tools we've built so removing the
misleading flag and the feature itself.

Since the associated string is removed, change the existing string
for NTP to the one approved by UX.

BUG=
==========

[commit-bot: I haz the power, 2016-11-08 18:46:16]

Committed patchset #4 (id:80001)

[commit-bot: I haz the power, 2016-11-08 19:08:39]

Description was changed from

==========
[Offline Pages] Remove a debugging feature and a misleading flag.

The flag called "IsBackgroundLoadingEnabled" was being used to gate
a debug feature for saving a linked page as MHTML.  This is no longer
needed with the various testing tools we've built so removing the
misleading flag and the feature itself.

Since the associated string is removed, change the existing string
for NTP to the one approved by UX.

BUG=
==========

to

==========
[Offline Pages] Remove a debugging feature and a misleading flag.

The flag called "IsBackgroundLoadingEnabled" was being used to gate
a debug feature for saving a linked page as MHTML.  This is no longer
needed with the various testing tools we've built so removing the
misleading flag and the feature itself.

Since the associated string is removed, change the existing string
for NTP to the one approved by UX.

BUG=

Committed: https://crrev.com/daa8ffc109069ede17d1d6c313355011b972ec89
Cr-Commit-Position: refs/heads/master@{#430671}
==========

[commit-bot: I haz the power, 2016-11-08 19:08:40]

Patchset 4 (id:??) landed as
https://crrev.com/daa8ffc109069ede17d1d6c313355011b972ec89
Cr-Commit-Position: refs/heads/master@{#430671}