Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2480753003: Use a new flag to control showing "DOWNLOAD PAGE LATER" in error pages (Closed)

Created:
4 years, 1 month ago by jianli
Modified:
4 years, 1 month ago
CC:
chromium-reviews, dewittj+watch_chromium.org, fgorski+watch_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, asvitkine+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a new flag to control showing "DOWNLOAD PAGE LATER" in error pages BUG=none Committed: https://crrev.com/3d94aed0544e16abdf31163938bc7b644fdedcf4 Cr-Commit-Position: refs/heads/master@{#430452}

Patch Set 1 #

Patch Set 2 : Update histogram for about unittest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -3 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M components/error_page/common/localized_error.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/offline_pages/offline_page_feature.h View 2 chunks +5 lines, -2 lines 0 comments Download
M components/offline_pages/offline_page_feature.cc View 2 chunks +8 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
jianli
dimich for everything mmenke for components/error_page/common/localized_error.cc
4 years, 1 month ago (2016-11-04 22:23:30 UTC) #2
Dmitry Titov
lgtm
4 years, 1 month ago (2016-11-04 22:39:04 UTC) #5
mmenke
On 2016/11/04 22:39:04, Dmitry Titov wrote: > lgtm components/error_page/common/localized_error.cc LGTM. Feel free to TBR me ...
4 years, 1 month ago (2016-11-07 14:58:05 UTC) #8
jianli
holte for histograms
4 years, 1 month ago (2016-11-07 22:05:53 UTC) #12
Steven Holte
lgtm
4 years, 1 month ago (2016-11-08 00:48:24 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2480753003/20001
4 years, 1 month ago (2016-11-08 00:50:31 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-08 00:57:28 UTC) #19
commit-bot: I haz the power
4 years, 1 month ago (2016-11-08 01:17:21 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3d94aed0544e16abdf31163938bc7b644fdedcf4
Cr-Commit-Position: refs/heads/master@{#430452}

Powered by Google App Engine
This is Rietveld 408576698