Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: components/offline_pages/offline_page_model_impl_unittest.cc

Issue 2477943002: [Offline Pages] Remove a debugging feature and a misleading flag. (Closed)
Patch Set: Rebased. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/offline_pages/offline_page_feature.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/offline_page_model_impl_unittest.cc
diff --git a/components/offline_pages/offline_page_model_impl_unittest.cc b/components/offline_pages/offline_page_model_impl_unittest.cc
index 72135f0943f89db5976ba78f40b0e1e9f3b07555..e9cdd58ef4e60c7f8546d48794cd626192166154 100644
--- a/components/offline_pages/offline_page_model_impl_unittest.cc
+++ b/components/offline_pages/offline_page_model_impl_unittest.cc
@@ -1213,25 +1213,6 @@ TEST(CommandLineFlagsTest, OffliningRecentPages) {
EXPECT_TRUE(offline_pages::IsOffliningRecentPagesEnabled());
}
-TEST(CommandLineFlagsTest, OfflinePagesBackgroundLoading) {
- // Enable offline bookmarks feature first.
- // TODO(dimich): once offline pages are enabled by default, remove this.
- std::unique_ptr<base::test::ScopedFeatureList> scoped_feature_list(
- new base::test::ScopedFeatureList);
- scoped_feature_list->InitAndEnableFeature(kOfflineBookmarksFeature);
-
- // This feature is still disabled by default.
- EXPECT_FALSE(offline_pages::IsOfflinePagesBackgroundLoadingEnabled());
-
- // Check if feature is correctly enabled by command-line flag.
- scoped_feature_list.reset(new base::test::ScopedFeatureList);
- scoped_feature_list->InitFromCommandLine(
- std::string(kOfflineBookmarksFeature.name) + "," +
- kOfflinePagesBackgroundLoadingFeature.name,
- "");
- EXPECT_TRUE(offline_pages::IsOfflinePagesBackgroundLoadingEnabled());
-}
-
TEST(CommandLineFlagsTest, OfflinePagesSharing) {
// Enable offline bookmarks feature first.
// TODO(dimich): once offline pages are enabled by default, remove this.
« no previous file with comments | « components/offline_pages/offline_page_feature.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698