Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2477703002: Remove now unused Balsa code. (Closed)

Created:
4 years, 1 month ago by Ryan Hamilton
Modified:
4 years, 1 month ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove now unused Balsa code. Merge internal change 137947300 Committed: https://crrev.com/0fe99c3f55d0ddd639516752746b785294f60e58 Cr-Commit-Position: refs/heads/master@{#429629}

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7170 lines) Patch
M net/BUILD.gn View 6 chunks +0 lines, -31 lines 0 comments Download
M net/net.gypi View 3 chunks +0 lines, -7 lines 0 comments Download
D net/tools/balsa/balsa_enums.h View 1 chunk +0 lines, -116 lines 0 comments Download
D net/tools/balsa/balsa_frame.h View 1 chunk +0 lines, -258 lines 0 comments Download
D net/tools/balsa/balsa_frame.cc View 1 chunk +0 lines, -1575 lines 0 comments Download
D net/tools/balsa/balsa_frame_test.cc View 1 chunk +0 lines, -599 lines 0 comments Download
D net/tools/balsa/balsa_headers.h View 1 chunk +0 lines, -1143 lines 0 comments Download
D net/tools/balsa/balsa_headers.cc View 1 chunk +0 lines, -981 lines 0 comments Download
D net/tools/balsa/balsa_headers_test.cc View 1 chunk +0 lines, -390 lines 0 comments Download
D net/tools/balsa/balsa_headers_token_utils.h View 1 chunk +0 lines, -61 lines 0 comments Download
D net/tools/balsa/balsa_headers_token_utils.cc View 1 chunk +0 lines, -142 lines 0 comments Download
D net/tools/balsa/balsa_visitor_interface.h View 1 chunk +0 lines, -180 lines 0 comments Download
D net/tools/balsa/buffer_interface.h View 1 chunk +0 lines, -121 lines 0 comments Download
D net/tools/balsa/http_message_constants.h View 1 chunk +0 lines, -17 lines 0 comments Download
D net/tools/balsa/http_message_constants.cc View 1 chunk +0 lines, -146 lines 0 comments Download
D net/tools/balsa/noop_balsa_visitor.h View 1 chunk +0 lines, -62 lines 0 comments Download
D net/tools/balsa/simple_buffer.h View 1 chunk +0 lines, -93 lines 0 comments Download
D net/tools/balsa/simple_buffer.cc View 1 chunk +0 lines, -208 lines 0 comments Download
D net/tools/balsa/string_piece_utils.h View 1 chunk +0 lines, -37 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_client.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_in_memory_cache_test.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M net/tools/quic/quic_simple_server_stream_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/tools/quic/quic_spdy_client_stream.cc View 1 chunk +0 lines, -1 line 0 comments Download
D net/tools/quic/spdy_balsa_utils.h View 1 chunk +0 lines, -42 lines 0 comments Download
D net/tools/quic/spdy_balsa_utils.cc View 1 chunk +0 lines, -318 lines 0 comments Download
D net/tools/quic/spdy_balsa_utils_test.cc View 1 chunk +0 lines, -132 lines 0 comments Download
D net/tools/quic/test_tools/http_message.h View 1 chunk +0 lines, -127 lines 0 comments Download
D net/tools/quic/test_tools/http_message.cc View 1 chunk +0 lines, -156 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 2 chunks +1 line, -2 lines 0 comments Download
D net/tools/quic/test_tools/simple_client.h View 1 chunk +0 lines, -165 lines 0 comments Download
D net/tools/quic/test_tools/simple_client.cc View 1 chunk +0 lines, -52 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 26 (19 generated)
Ryan Hamilton
4 years, 1 month ago (2016-11-03 12:50:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477703002/40001
4 years, 1 month ago (2016-11-03 17:21:12 UTC) #17
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 1 month ago (2016-11-03 17:21:14 UTC) #19
Zhongyi Shi
lgtm
4 years, 1 month ago (2016-11-03 17:24:03 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2477703002/40001
4 years, 1 month ago (2016-11-03 17:24:35 UTC) #22
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-03 17:30:30 UTC) #24
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 17:48:07 UTC) #26
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0fe99c3f55d0ddd639516752746b785294f60e58
Cr-Commit-Position: refs/heads/master@{#429629}

Powered by Google App Engine
This is Rietveld 408576698