Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(280)

Issue 2470353002: Remove any use of BalsaHeaders and HttpMessage from QuicTestClient. (Closed)

Created:
4 years, 1 month ago by Ryan Hamilton
Modified:
4 years, 1 month ago
Reviewers:
Zhongyi Shi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove any use of BalsaHeaders and HttpMessage from QuicTestClient. Merge internal change: 137947300 BUG= Committed: https://crrev.com/2fec850438d6e4595e5fe255749dfdb8e91cc34d Cr-Commit-Position: refs/heads/master@{#429615}

Patch Set 1 #

Patch Set 2 : format #

Patch Set 3 : Rebase #

Total comments: 4

Patch Set 4 : Fix #

Patch Set 5 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -182 lines) Patch
M net/quic/core/spdy_utils.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/quic/core/spdy_utils_test.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 2 3 4 27 chunks +164 lines, -97 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 1 4 chunks +22 lines, -7 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 1 11 chunks +46 lines, -77 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 23 (16 generated)
Ryan Hamilton
4 years, 1 month ago (2016-11-03 12:49:44 UTC) #6
Zhongyi Shi
https://codereview.chromium.org/2470353002/diff/40001/net/tools/quic/end_to_end_test.cc File net/tools/quic/end_to_end_test.cc (right): https://codereview.chromium.org/2470353002/diff/40001/net/tools/quic/end_to_end_test.cc#newcode1243 net/tools/quic/end_to_end_test.cc:1243: client_->SendMessage(headers, body); I think this should be: client_->SendCustomSynchronousRequest(headers, body); ...
4 years, 1 month ago (2016-11-03 15:15:22 UTC) #9
Ryan Hamilton
https://codereview.chromium.org/2470353002/diff/40001/net/tools/quic/end_to_end_test.cc File net/tools/quic/end_to_end_test.cc (right): https://codereview.chromium.org/2470353002/diff/40001/net/tools/quic/end_to_end_test.cc#newcode1243 net/tools/quic/end_to_end_test.cc:1243: client_->SendMessage(headers, body); On 2016/11/03 15:15:22, Zhongyi Shi wrote: > ...
4 years, 1 month ago (2016-11-03 15:26:18 UTC) #14
Zhongyi Shi
lgtm
4 years, 1 month ago (2016-11-03 15:43:47 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470353002/80001
4 years, 1 month ago (2016-11-03 16:07:58 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-11-03 16:35:22 UTC) #21
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 16:43:40 UTC) #23
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/2fec850438d6e4595e5fe255749dfdb8e91cc34d
Cr-Commit-Position: refs/heads/master@{#429615}

Powered by Google App Engine
This is Rietveld 408576698