Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2476573003:
[Devtools] Renamed network timeline to "Waterfall" (Closed)
|
Created:
4 years, 1 month ago by allada Modified:
4 years, 1 month ago CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Description[Devtools] Renamed network timeline to "Waterfall"
This patch renames the timeline in network panel to waterfall per
paulirish@.
R=dgozman,paulirish
BUG=653738
Committed: https://crrev.com/2e7f8e7887cf4d32137d83dfd8d094309fd7c7ce
Cr-Commit-Position: refs/heads/master@{#430112}
Patch Set 1 #Patch Set 2 : Merge branch 'ADD_WISKERS' into RENAME_TIMELINE_WATERFALL #
Depends on Patchset: Messages
Total messages: 22 (14 generated)
PTL. I will have another patch after we remove the old timeline to rename all references to timeline to waterfall as well. This patch is only to do it for the UI per paulirish@.
The CQ bit was checked by allada@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
Description was changed from ========== [Devtools] Renamed network timeline Waterfall from Timeline This patch renames the timeline in network panel to waterfall per paulirish@. R=dgozman,paulirish BUG=653738 ========== to ========== [Devtools] Renamed network timeline to "Waterfall" This patch renames the timeline in network panel to waterfall per paulirish@. R=dgozman,paulirish BUG=653738 ==========
The CQ bit was checked by allada@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
lgtm
The CQ bit was checked by allada@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Devtools] Renamed network timeline to "Waterfall" This patch renames the timeline in network panel to waterfall per paulirish@. R=dgozman,paulirish BUG=653738 ========== to ========== [Devtools] Renamed network timeline to "Waterfall" This patch renames the timeline in network panel to waterfall per paulirish@. R=dgozman,paulirish BUG=653738 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [Devtools] Renamed network timeline to "Waterfall" This patch renames the timeline in network panel to waterfall per paulirish@. R=dgozman,paulirish BUG=653738 ========== to ========== [Devtools] Renamed network timeline to "Waterfall" This patch renames the timeline in network panel to waterfall per paulirish@. R=dgozman,paulirish BUG=653738 Committed: https://crrev.com/2e7f8e7887cf4d32137d83dfd8d094309fd7c7ce Cr-Commit-Position: refs/heads/master@{#430112} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/2e7f8e7887cf4d32137d83dfd8d094309fd7c7ce Cr-Commit-Position: refs/heads/master@{#430112} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
