Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(288)

Issue 2474233002: [Devtools] Added "wiskers" to new network timeline for colored mode (Closed)

Created:
4 years, 1 month ago by allada
Modified:
4 years, 1 month ago
Reviewers:
paulirish, dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Added "wiskers" to new network timeline for colored mode This patch adds "wiskers" for stalled/queued timeing bars in simplified view mode. See: http://imgur.com/a/bRXYL R=dgozman,paulirish BUG=653738 Committed: https://crrev.com/898d7400bebb7681d663255a7ffb60bcfcb57419 Cr-Commit-Position: refs/heads/master@{#430052}

Patch Set 1 : [Devtools] Added "wiskers" to new network timeline for colored mode #

Total comments: 4

Patch Set 2 : wq #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -6 lines) Patch
M third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js View 1 5 chunks +37 lines, -6 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (10 generated)
allada
PTL
4 years, 1 month ago (2016-11-03 22:17:14 UTC) #4
dgozman
lgtm https://codereview.chromium.org/2474233002/diff/60001/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js File third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js (right): https://codereview.chromium.org/2474233002/diff/60001/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js#newcode434 third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:434: .find(data => data.name === WebInspector.RequestTimeRangeNames.Total); formatting is off ...
4 years, 1 month ago (2016-11-04 16:41:01 UTC) #5
allada
done https://codereview.chromium.org/2474233002/diff/60001/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js File third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js (right): https://codereview.chromium.org/2474233002/diff/60001/third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js#newcode434 third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:434: .find(data => data.name === WebInspector.RequestTimeRangeNames.Total); On 2016/11/04 16:41:00, ...
4 years, 1 month ago (2016-11-04 18:17:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474233002/80001
4 years, 1 month ago (2016-11-04 18:18:40 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/300071) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, ...
4 years, 1 month ago (2016-11-04 18:22:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474233002/100001
4 years, 1 month ago (2016-11-04 19:10:00 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:100001)
4 years, 1 month ago (2016-11-04 22:58:57 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-04 23:00:42 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/898d7400bebb7681d663255a7ffb60bcfcb57419
Cr-Commit-Position: refs/heads/master@{#430052}

Powered by Google App Engine
This is Rietveld 408576698