Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js

Issue 2476573003: [Devtools] Renamed network timeline to "Waterfall" (Closed)
Patch Set: Merge branch 'ADD_WISKERS' into RENAME_TIMELINE_WATERFALL Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
index beea55f537dab65fa12e5e26af87e2499181c881..59b3a7814baaf12076723bbe80d3bd4b235e8194 100644
--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
@@ -256,7 +256,7 @@ WebInspector.NetworkLogViewColumns = class {
this._timelineHeaderElement.addEventListener(
'contextmenu', event => this._innerHeaderContextMenu(new WebInspector.ContextMenu(event)));
var innerElement = this._timelineHeaderElement.createChild('div');
- innerElement.textContent = WebInspector.UIString('Timeline');
+ innerElement.textContent = WebInspector.UIString('Waterfall');
this._timelineColumnSortIcon = this._timelineHeaderElement.createChild('div', 'sort-order-icon-container')
.createChild('div', 'sort-order-icon');
@@ -517,7 +517,7 @@ WebInspector.NetworkLogViewColumns = class {
if (Runtime.experiments.isEnabled('canvasNetworkTimeline')) {
contextMenu.appendSeparator();
var timelineSortIds = WebInspector.NetworkLogViewColumns.TimelineSortIds;
- var timelineSubMenu = contextMenu.appendSubMenuItem(WebInspector.UIString('Timeline'));
+ var timelineSubMenu = contextMenu.appendSubMenuItem(WebInspector.UIString('Waterfall'));
timelineSubMenu.appendCheckboxItem(
WebInspector.UIString('Start Time'), setTimelineMode.bind(this, timelineSortIds.StartTime),
this._activeTimelineSortId === timelineSortIds.StartTime);
@@ -1021,7 +1021,7 @@ WebInspector.NetworkLogViewColumns._defaultColumns = [
},
{
id: 'timeline',
- title: WebInspector.UIString('Timeline'),
+ title: WebInspector.UIString('Waterfall'),
visible: true,
weight: 40,
sortable: false,
@@ -1030,14 +1030,14 @@ WebInspector.NetworkLogViewColumns._defaultColumns = [
entries: [
{
id: 'starttime',
- title: WebInspector.UIString('Timeline \u2013 Start Time'),
+ title: WebInspector.UIString('Waterfall \u2013 Start Time'),
sort: WebInspector.DataGrid.Order.Ascending,
sortingFunction: WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, 'startTime'),
calculator: WebInspector.NetworkLogViewColumns._calculatorTypes.Time
},
{
id: 'responsetime',
- title: WebInspector.UIString('Timeline \u2013 Response Time'),
+ title: WebInspector.UIString('Waterfall \u2013 Response Time'),
sort: WebInspector.DataGrid.Order.Ascending,
sortingFunction:
WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, 'responseReceivedTime'),
@@ -1045,21 +1045,21 @@ WebInspector.NetworkLogViewColumns._defaultColumns = [
},
{
id: 'endtime',
- title: WebInspector.UIString('Timeline \u2013 End Time'),
+ title: WebInspector.UIString('Waterfall \u2013 End Time'),
sort: WebInspector.DataGrid.Order.Ascending,
sortingFunction: WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, 'endTime'),
calculator: WebInspector.NetworkLogViewColumns._calculatorTypes.Time
},
{
id: 'duration',
- title: WebInspector.UIString('Timeline \u2013 Total Duration'),
+ title: WebInspector.UIString('Waterfall \u2013 Total Duration'),
sort: WebInspector.DataGrid.Order.Descending,
sortingFunction: WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, 'duration'),
calculator: WebInspector.NetworkLogViewColumns._calculatorTypes.Duration
},
{
id: 'latency',
- title: WebInspector.UIString('Timeline \u2013 Latency'),
+ title: WebInspector.UIString('Waterfall \u2013 Latency'),
sort: WebInspector.DataGrid.Order.Descending,
sortingFunction: WebInspector.NetworkDataGridNode.RequestPropertyComparator.bind(null, 'latency'),
calculator: WebInspector.NetworkLogViewColumns._calculatorTypes.Duration
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698