components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc - Issue 2476493003: Remove FundamentalValue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc

Issue 2476493003: Remove FundamentalValue

Patch Set: Fix Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/password_manager/core/browser/password_manager_metrics_util.cc ('k') | components/policy/core/browser/android/policy_converter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc

diff --git a/components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc b/components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc

index b14f21f23bafec7dd3ba57a78059104e5499e0a6..7f2c59994af5b5d00efe31c15b041fac8796d1d7 100644

--- a/components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc

+++ b/components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc

@@ -76,7 +76,7 @@ enum PasswordManagerPreferencesInitialAndFinalValues {

};

syncer::SyncData CreatePrefSyncData(const std::string& name, bool value) {

- base::FundamentalValue bool_value(value);

+ base::Value bool_value(value);

std::string serialized;

base::JSONWriter::Write(bool_value, &serialized);

sync_pb::EntitySpecifics specifics;