Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: components/policy/core/browser/android/policy_converter.cc

Issue 2476493003: Remove FundamentalValue
Patch Set: Fix Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/browser/android/policy_converter.cc
diff --git a/components/policy/core/browser/android/policy_converter.cc b/components/policy/core/browser/android/policy_converter.cc
index 35911c76bf070c10d3a35a9537a81ea3fb617c67..9999d9669b60b719d55794383ece01339a02fd15 100644
--- a/components/policy/core/browser/android/policy_converter.cc
+++ b/components/policy/core/browser/android/policy_converter.cc
@@ -58,7 +58,7 @@ void PolicyConverter::SetPolicyBoolean(JNIEnv* env,
jboolean value) {
SetPolicyValue(
ConvertJavaStringToUTF8(env, policyKey),
- base::MakeUnique<base::FundamentalValue>(static_cast<bool>(value)));
+ base::MakeUnique<base::Value>(static_cast<bool>(value)));
}
void PolicyConverter::SetPolicyInteger(JNIEnv* env,
@@ -67,7 +67,7 @@ void PolicyConverter::SetPolicyInteger(JNIEnv* env,
jint value) {
SetPolicyValue(
ConvertJavaStringToUTF8(env, policyKey),
- base::MakeUnique<base::FundamentalValue>(static_cast<int>(value)));
+ base::MakeUnique<base::Value>(static_cast<int>(value)));
}
void PolicyConverter::SetPolicyString(JNIEnv* env,
@@ -121,16 +121,16 @@ std::unique_ptr<base::Value> PolicyConverter::ConvertValueToSchema(
std::string string_value;
if (value->GetAsString(&string_value)) {
if (string_value.compare("true") == 0)
- return base::MakeUnique<base::FundamentalValue>(true);
+ return base::MakeUnique<base::Value>(true);
if (string_value.compare("false") == 0)
- return base::MakeUnique<base::FundamentalValue>(false);
+ return base::MakeUnique<base::Value>(false);
return value;
}
int int_value = 0;
if (value->GetAsInteger(&int_value))
- return base::MakeUnique<base::FundamentalValue>(int_value != 0);
+ return base::MakeUnique<base::Value>(int_value != 0);
return value;
}
@@ -140,7 +140,7 @@ std::unique_ptr<base::Value> PolicyConverter::ConvertValueToSchema(
if (value->GetAsString(&string_value)) {
int int_value = 0;
if (base::StringToInt(string_value, &int_value))
- return base::MakeUnique<base::FundamentalValue>(int_value);
+ return base::MakeUnique<base::Value>(int_value);
}
return value;
}
@@ -150,7 +150,7 @@ std::unique_ptr<base::Value> PolicyConverter::ConvertValueToSchema(
if (value->GetAsString(&string_value)) {
double double_value = 0;
if (base::StringToDouble(string_value, &double_value))
- return base::MakeUnique<base::FundamentalValue>(double_value);
+ return base::MakeUnique<base::Value>(double_value);
}
return value;
}

Powered by Google App Engine
This is Rietveld 408576698