Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(350)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Unified Diff: components/password_manager/core/browser/password_manager_metrics_util.cc
Issue
2476493003
:
Remove FundamentalValue
Patch Set: Fix
Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Jump to:
base/json/json_parser.cc
base/json/json_writer_unittest.cc
base/trace_event/trace_event_argument_unittest.cc
base/trace_event/trace_event_memory_overhead.cc
base/values.h
base/values.cc
base/values_unittest.cc
chrome/browser/chromeos/arc/arc_policy_bridge_unittest.cc
chrome/browser/chromeos/arc/policy/arc_policy_bridge_unittest.cc
chrome/browser/chromeos/display/display_preferences_unittest.cc
chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc
chrome/browser/chromeos/extensions/file_manager/private_api_misc.cc
chrome/browser/chromeos/extensions/file_manager/private_api_tasks.cc
chrome/browser/chromeos/extensions/info_private_api.cc
chrome/browser/chromeos/extensions/input_method_api.cc
chrome/browser/chromeos/extensions/users_private/users_private_api.cc
chrome/browser/chromeos/extensions/wallpaper_private_api.cc
chrome/browser/chromeos/file_system_provider/operations/read_file_unittest.cc
chrome/browser/chromeos/file_system_provider/provided_file_system_unittest.cc
chrome/browser/chromeos/login/app_launch_signin_screen.cc
chrome/browser/chromeos/login/kiosk_browsertest.cc
chrome/browser/chromeos/login/saml/saml_browsertest.cc
chrome/browser/chromeos/login/users/avatar/user_image_manager_impl.cc
chrome/browser/chromeos/net/network_state_notifier_unittest.cc
chrome/browser/chromeos/ownership/owner_settings_service_chromeos_unittest.cc
chrome/browser/chromeos/policy/auto_enrollment_client_unittest.cc
chrome/browser/chromeos/policy/configuration_policy_handler_chromeos.cc
chrome/browser/chromeos/policy/configuration_policy_handler_chromeos_unittest.cc
chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
chrome/browser/chromeos/policy/device_local_account_policy_provider.cc
chrome/browser/chromeos/policy/device_local_account_policy_service_unittest.cc
chrome/browser/chromeos/policy/device_policy_decoder_chromeos.cc
chrome/browser/chromeos/policy/device_status_collector_browsertest.cc
chrome/browser/chromeos/policy/login_profile_policy_provider.cc
chrome/browser/chromeos/policy/login_screen_default_policy_browsertest.cc
chrome/browser/chromeos/policy/recommendation_restorer_unittest.cc
chrome/browser/chromeos/policy/remote_commands/device_command_screenshot_job_unittest.cc
chrome/browser/chromeos/policy/user_cloud_policy_manager_chromeos_unittest.cc
chrome/browser/chromeos/proxy_config_service_impl_unittest.cc
chrome/browser/chromeos/proxy_cros_settings_parser.cc
chrome/browser/chromeos/session_length_limiter_unittest.cc
chrome/browser/chromeos/settings/cros_settings.cc
chrome/browser/chromeos/settings/cros_settings_unittest.cc
chrome/browser/chromeos/settings/device_settings_provider_unittest.cc
chrome/browser/chromeos/settings/scoped_cros_settings_test_helper.cc
chrome/browser/chromeos/settings/stub_cros_settings_provider_unittest.cc
chrome/browser/chromeos/status/data_promo_notification_unittest.cc
chrome/browser/chromeos/system/automatic_reboot_manager_unittest.cc
chrome/browser/chromeos/system/tray_accessibility_browsertest.cc
chrome/browser/component_updater/chrome_component_updater_configurator_unittest.cc
chrome/browser/content_settings/content_settings_default_provider_unittest.cc
chrome/browser/content_settings/content_settings_internal_extension_provider.cc
chrome/browser/content_settings/content_settings_origin_identifier_value_map_unittest.cc
chrome/browser/content_settings/content_settings_policy_provider_unittest.cc
chrome/browser/content_settings/content_settings_pref_provider_unittest.cc
chrome/browser/content_settings/content_settings_supervised_provider_unittest.cc
chrome/browser/content_settings/host_content_settings_map_unittest.cc
chrome/browser/custom_handlers/protocol_handler_registry.cc
chrome/browser/devtools/devtools_ui_bindings.cc
chrome/browser/devtools/devtools_window.cc
chrome/browser/download/download_query.h
chrome/browser/download/download_query_unittest.cc
chrome/browser/extensions/api/automation_internal/automation_internal_api.cc
chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_api.cc
chrome/browser/extensions/api/commands/command_service.cc
chrome/browser/extensions/api/content_settings/content_settings_store.cc
chrome/browser/extensions/api/cryptotoken_private/cryptotoken_private_api.cc
chrome/browser/extensions/api/declarative/rules_registry_with_cache_unittest.cc
chrome/browser/extensions/api/developer_private/developer_private_api.cc
chrome/browser/extensions/api/dial/dial_api.cc
chrome/browser/extensions/api/downloads/downloads_api.cc
chrome/browser/extensions/api/easy_unlock_private/easy_unlock_private_connection_manager.cc
chrome/browser/extensions/api/extension_action/extension_action_api.cc
chrome/browser/extensions/api/file_system/file_system_api.cc
chrome/browser/extensions/api/input_ime/input_ime_api.cc
chrome/browser/extensions/api/input_ime/input_ime_api_chromeos.cc
chrome/browser/extensions/api/input_ime/input_ime_api_nonchromeos.cc
chrome/browser/extensions/api/instance_id/instance_id_api.cc
chrome/browser/extensions/api/language_settings_private/language_settings_private_api.cc
chrome/browser/extensions/api/media_galleries/media_galleries_api.cc
chrome/browser/extensions/api/metrics_private/metrics_private_api.cc
chrome/browser/extensions/api/module/module.cc
chrome/browser/extensions/api/networking_config_chromeos_apitest_chromeos.cc
chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
chrome/browser/extensions/api/notifications/notifications_api.cc
chrome/browser/extensions/api/omnibox/omnibox_api.cc
chrome/browser/extensions/api/permissions/permissions_api_helpers_unittest.cc
chrome/browser/extensions/api/preference/preference_api.cc
chrome/browser/extensions/api/screenlock_private/screenlock_private_api.cc
chrome/browser/extensions/api/settings_overrides/settings_overrides_api.cc
chrome/browser/extensions/api/settings_private/settings_private_api.cc
chrome/browser/extensions/api/settings_private/settings_private_delegate.cc
chrome/browser/extensions/api/storage/policy_value_store_unittest.cc
chrome/browser/extensions/api/sync_file_system/sync_file_system_api.cc
chrome/browser/extensions/api/tabs/tabs_event_router.cc
chrome/browser/extensions/api/terminal/terminal_private_api.cc
chrome/browser/extensions/api/webstore_private/webstore_private_api.cc
chrome/browser/extensions/chrome_app_sorting_unittest.cc
chrome/browser/extensions/error_console/error_console.cc
chrome/browser/extensions/extension_message_bubble_controller.cc
chrome/browser/extensions/extension_service_unittest.cc
chrome/browser/extensions/extension_storage_monitor.cc
chrome/browser/extensions/extension_util.cc
chrome/browser/extensions/launch_util.cc
chrome/browser/extensions/menu_manager.h
chrome/browser/extensions/scripting_permissions_modifier.cc
chrome/browser/extensions/scripting_permissions_modifier_unittest.cc
chrome/browser/io_thread.cc
chrome/browser/metrics/android_metrics_provider.cc
chrome/browser/metrics/chrome_metrics_service_accessor_unittest.cc
chrome/browser/net/disk_cache_dir_policy_handler_unittest.cc
chrome/browser/net/errorpage_browsertest.cc
chrome/browser/password_manager/chrome_password_manager_client_unittest.cc
chrome/browser/plugins/chrome_plugin_service_filter_unittest.cc
chrome/browser/plugins/plugin_info_message_filter_unittest.cc
chrome/browser/plugins/plugin_policy_handler.cc
chrome/browser/policy/cloud/cloud_policy_browsertest.cc
chrome/browser/policy/configuration_policy_handler_list_factory.cc
chrome/browser/policy/default_geolocation_policy_handler_unittest.cc
chrome/browser/policy/file_selection_dialogs_policy_handler_unittest.cc
chrome/browser/policy/javascript_policy_handler_unittest.cc
chrome/browser/policy/policy_browsertest.cc
chrome/browser/policy/policy_network_browsertest.cc
chrome/browser/policy/policy_startup_browsertest.cc
chrome/browser/policy/profile_policy_connector_unittest.cc
chrome/browser/prefs/chrome_command_line_pref_store.cc
chrome/browser/prefs/chrome_pref_service_unittest.cc
chrome/browser/prefs/command_line_pref_store.cc
chrome/browser/prefs/incognito_mode_prefs_unittest.cc
chrome/browser/prefs/synced_pref_change_registrar_browsertest.cc
chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc
chrome/browser/profiles/incognito_mode_policy_handler_unittest.cc
chrome/browser/profiles/profile_manager_unittest.cc
chrome/browser/safe_browsing/incident_reporting/extension_data_collection_unittest.cc
chrome/browser/safe_browsing/incident_reporting/preference_validation_delegate_unittest.cc
chrome/browser/search/contextual_search_policy_handler_android_unittest.cc
chrome/browser/sessions/restore_on_startup_policy_handler_unittest.cc
chrome/browser/signin/easy_unlock_service_unittest_chromeos.cc
chrome/browser/speech/extension_api/tts_extension_api.cc
chrome/browser/supervised_user/child_accounts/child_account_service.cc
chrome/browser/supervised_user/legacy/supervised_user_pref_mapping_service.cc
chrome/browser/supervised_user/legacy/supervised_user_pref_mapping_service_unittest.cc
chrome/browser/supervised_user/legacy/supervised_user_registration_utility.cc
chrome/browser/supervised_user/legacy/supervised_user_shared_settings_service_unittest.cc
chrome/browser/supervised_user/supervised_user_browsertest.cc
chrome/browser/supervised_user/supervised_user_pref_store_unittest.cc
chrome/browser/supervised_user/supervised_user_resource_throttle_browsertest.cc
chrome/browser/sync/test/integration/single_client_password_manager_setting_migrator_service_sync_test.cc
chrome/browser/sync/test/integration/two_client_app_list_sync_test.cc
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_unittest.cc
chrome/browser/ui/bookmarks/bookmark_context_menu_controller_unittest.cc
chrome/browser/ui/chrome_select_file_policy_unittest.cc
chrome/browser/ui/cocoa/applescript/apple_event_util_unittest.mm
chrome/browser/ui/cocoa/bookmarks/bookmark_bar_controller_unittest.mm
chrome/browser/ui/startup/startup_browser_creator_browsertest.cc
chrome/browser/ui/views/bookmarks/bookmark_bar_view_unittest.cc
chrome/browser/ui/webui/app_launcher_login_handler.cc
chrome/browser/ui/webui/bidi_checker_web_ui_test.cc
chrome/browser/ui/webui/browsing_history_handler.cc
chrome/browser/ui/webui/chromeos/cryptohome_web_ui_handler.cc
chrome/browser/ui/webui/chromeos/drive_internals_ui.cc
chrome/browser/ui/webui/chromeos/emulator/device_emulator_message_handler.cc
chrome/browser/ui/webui/chromeos/first_run/first_run_handler.cc
chrome/browser/ui/webui/chromeos/login/enable_debugging_screen_handler.cc
chrome/browser/ui/webui/chromeos/mobile_setup_ui.cc
chrome/browser/ui/webui/chromeos/slow_ui.cc
chrome/browser/ui/webui/crashes_ui.cc
chrome/browser/ui/webui/foreign_session_handler.cc
chrome/browser/ui/webui/help/help_handler.cc
chrome/browser/ui/webui/history_login_handler.cc
chrome/browser/ui/webui/invalidations_message_handler.cc
chrome/browser/ui/webui/local_discovery/local_discovery_ui_handler.cc
chrome/browser/ui/webui/md_downloads/downloads_list_tracker.cc
chrome/browser/ui/webui/media_router/media_router_webui_message_handler.cc
chrome/browser/ui/webui/ntp/app_launcher_handler.cc
chrome/browser/ui/webui/offline/offline_internals_ui_message_handler.cc
chrome/browser/ui/webui/options/browser_options_handler.cc
chrome/browser/ui/webui/options/certificate_manager_handler.cc
chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc
chrome/browser/ui/webui/options/chromeos/date_time_options_handler.cc
chrome/browser/ui/webui/options/chromeos/display_options_handler.cc
chrome/browser/ui/webui/options/chromeos/keyboard_handler.cc
chrome/browser/ui/webui/options/chromeos/pointer_handler.cc
chrome/browser/ui/webui/options/chromeos/power_handler.cc
chrome/browser/ui/webui/options/chromeos/shared_options_browsertest.cc
chrome/browser/ui/webui/options/clear_browser_data_handler.cc
chrome/browser/ui/webui/options/content_settings_handler.cc
chrome/browser/ui/webui/options/core_options_handler.cc
chrome/browser/ui/webui/options/font_settings_handler.cc
chrome/browser/ui/webui/options/import_data_handler.cc
chrome/browser/ui/webui/options/manage_profile_handler.cc
chrome/browser/ui/webui/options/password_manager_handler.cc
chrome/browser/ui/webui/options/preferences_browsertest.cc
chrome/browser/ui/webui/options/reset_profile_settings_handler.cc
chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.cc
chrome/browser/ui/webui/policy_ui_browsertest.cc
chrome/browser/ui/webui/print_preview/print_preview_handler.cc
chrome/browser/ui/webui/print_preview/print_preview_ui.cc
chrome/browser/ui/webui/quota_internals/quota_internals_handler.cc
chrome/browser/ui/webui/settings/certificates_handler.cc
chrome/browser/ui/webui/settings/chromeos/change_picture_handler.cc
chrome/browser/ui/webui/settings/chromeos/cups_printers_handler.cc
chrome/browser/ui/webui/settings/chromeos/date_time_handler.cc
chrome/browser/ui/webui/settings/chromeos/device_keyboard_handler.cc
chrome/browser/ui/webui/settings/chromeos/device_pointer_handler.cc
chrome/browser/ui/webui/settings/chromeos/device_storage_handler.cc
chrome/browser/ui/webui/settings/chromeos/easy_unlock_settings_handler.cc
chrome/browser/ui/webui/settings/font_handler.cc
chrome/browser/ui/webui/settings/metrics_reporting_handler_unittest.cc
chrome/browser/ui/webui/settings/profile_info_handler.cc
chrome/browser/ui/webui/settings/protocol_handlers_handler.cc
chrome/browser/ui/webui/settings/safe_browsing_handler.cc
chrome/browser/ui/webui/settings/search_engines_handler.cc
chrome/browser/ui/webui/settings/settings_clear_browsing_data_handler.cc
chrome/browser/ui/webui/settings/settings_manage_profile_handler.cc
chrome/browser/ui/webui/settings/settings_startup_pages_handler.cc
chrome/browser/ui/webui/settings/site_settings_handler.cc
chrome/browser/ui/webui/signin/sync_confirmation_handler_unittest.cc
chrome/browser/ui/webui/signin/user_manager_screen_handler.cc
chrome/browser/ui/webui/site_settings_helper_unittest.cc
chrome/browser/ui/webui/snippets_internals_message_handler.cc
chrome/browser/ui/webui/sync_internals_message_handler.cc
chrome/browser/ui/webui/sync_internals_ui_unittest.cc
chrome/browser/ui/webui/translate_internals/translate_internals_handler.cc
chrome/browser/ui/webui/welcome_win10_handler.cc
chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc
chrome/common/extensions/manifest_unittest.cc
chrome/service/service_process_prefs.cc
chrome/test/base/javascript_browser_test.cc
chrome/test/chromedriver/alert_commands.cc
chrome/test/chromedriver/chrome/web_view_impl_unittest.cc
chrome/test/chromedriver/commands_unittest.cc
chrome/test/chromedriver/element_commands.cc
chrome/test/chromedriver/server/http_handler_unittest.cc
chrome/test/chromedriver/session_commands.cc
chromecast/base/device_capabilities_impl.cc
chromecast/base/device_capabilities_impl_unittest.cc
chromeos/dbus/fake_shill_manager_client.cc
chromeos/dbus/fake_shill_service_client.cc
chromeos/dbus/shill_device_client_unittest.cc
chromeos/dbus/shill_ipconfig_client_unittest.cc
chromeos/dbus/shill_manager_client_unittest.cc
chromeos/dbus/shill_profile_client_unittest.cc
chromeos/dbus/shill_service_client_unittest.cc
chromeos/network/network_device_handler_impl.cc
chromeos/network/network_device_handler_unittest.cc
chromeos/network/network_state_handler_unittest.cc
chromeos/network/onc/onc_translator_shill_to_onc.cc
chromeos/network/shill_property_handler.cc
chromeos/network/shill_property_handler_unittest.cc
components/arc/bluetooth/bluetooth_type_converters_unittest.cc
components/autofill/core/common/save_password_progress_logger.cc
components/browser_sync/profile_sync_service_unittest.cc
components/content_settings/core/browser/content_settings_binary_value_map.cc
components/content_settings/core/browser/content_settings_policy_provider.cc
components/content_settings/core/browser/content_settings_pref.cc
components/content_settings/core/browser/content_settings_provider_unittest.cc
components/content_settings/core/browser/content_settings_registry.cc
components/content_settings/core/browser/content_settings_rule_unittest.cc
components/content_settings/core/browser/content_settings_utils.cc
components/content_settings/core/browser/host_content_settings_map.cc
components/content_settings/core/browser/website_settings_registry_unittest.cc
components/cryptauth/cryptauth_device_manager_unittest.cc
components/cryptauth/cryptauth_enrollment_manager_unittest.cc
components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_test_utils.cc
components/dom_distiller/ios/distiller_page_ios.mm
components/json_schema/json_schema_validator_unittest_base.cc
components/login/base_screen_handler_utils.h
components/login/base_screen_handler_utils.cc
components/login/screens/screen_context.cc
components/ownership/owner_settings_service.cc
components/password_manager/core/browser/password_manager_metrics_util.cc
components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc
components/policy/core/browser/android/policy_converter.cc
components/policy/core/browser/android/policy_converter_unittest.cc
components/policy/core/browser/autofill_policy_handler_unittest.cc
components/policy/core/browser/configuration_policy_handler_unittest.cc
components/policy/core/browser/configuration_policy_pref_store_unittest.cc
components/policy/core/browser/proxy_policy_handler_unittest.cc
components/policy/core/browser/url_blacklist_policy_handler_unittest.cc
components/policy/core/common/cloud/cloud_policy_manager_unittest.cc
components/policy/core/common/cloud/user_cloud_policy_manager.cc
components/policy/core/common/cloud/user_cloud_policy_store_unittest.cc
components/policy/core/common/configuration_policy_provider_test.cc
components/policy/core/common/mac_util.cc
components/policy/core/common/policy_bundle_unittest.cc
components/policy/core/common/policy_map_unittest.cc
components/policy/core/common/policy_service_impl_unittest.cc
components/policy/core/common/policy_statistics_collector_unittest.cc
components/policy/core/common/preg_parser.cc
components/policy/core/common/preg_parser_unittest.cc
components/policy/core/common/registry_dict.cc
components/policy/core/common/registry_dict_unittest.cc
components/policy/core/common/schema_map_unittest.cc
components/policy/core/common/schema_unittest.cc
components/policy/tools/generate_policy_source.py
components/prefs/command_line_pref_store.cc
components/prefs/in_memory_pref_store_unittest.cc
components/prefs/json_pref_store_unittest.cc
components/prefs/overlay_user_pref_store_unittest.cc
components/prefs/pref_change_registrar_unittest.cc
components/prefs/pref_registry_simple.cc
components/prefs/pref_service.cc
components/prefs/pref_service_unittest.cc
components/prefs/pref_value_map.cc
components/prefs/pref_value_map_unittest.cc
components/prefs/pref_value_store_unittest.cc
components/prefs/testing_pref_store.cc
components/search_engines/default_search_manager_unittest.cc
components/search_engines/default_search_policy_handler_unittest.cc
components/search_engines/template_url_prepopulate_data_unittest.cc
components/sync/driver/sync_policy_handler_unittest.cc
components/sync/protocol/proto_value_conversions.cc
components/sync/syncable/entry_kernel.cc
components/sync_preferences/pref_model_associator_unittest.cc
components/test_runner/tracked_dictionary.cc
components/user_manager/user_manager_base.cc
components/user_prefs/tracked/pref_hash_calculator_unittest.cc
components/user_prefs/tracked/pref_hash_filter_unittest.cc
content/browser/appcache/appcache_internals_ui.cc
content/browser/devtools/protocol/devtools_protocol_handler_generator.py
content/browser/devtools/protocol_string.cc
content/browser/gpu/gpu_internals_ui.cc
content/browser/indexed_db/indexed_db_internals_ui.cc
content/browser/media/media_internals_proxy.cc
content/browser/renderer_host/pepper/pepper_socket_utils.cc
content/browser/service_worker/service_worker_internals_ui.cc
content/browser/tracing/etw_tracing_agent_win.cc
content/browser/tracing/tracing_ui.cc
content/browser/webui/web_ui_message_handler.cc
content/child/v8_value_converter_impl.cc
content/child/v8_value_converter_impl_unittest.cc
content/common/android/gin_java_bridge_value_unittest.cc
content/common/common_param_traits_unittest.cc
content/renderer/java/gin_java_bridge_value_converter.cc
content/shell/browser/shell_devtools_frontend.cc
dbus/values_util.cc
dbus/values_util_unittest.cc
device/bluetooth/bluez/bluetooth_service_attribute_value_bluez_unittest.cc
device/bluetooth/dbus/bluetooth_device_client.cc
device/bluetooth/dbus/fake_bluetooth_device_client.cc
extensions/browser/api/alarms/alarms_api.cc
extensions/browser/api/app_window/app_window_api.cc
extensions/browser/api/declarative/rules_cache_delegate.cc
extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc
extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc
extensions/browser/api/guest_view/web_view/web_view_internal_api.cc
extensions/browser/api/hid/hid_api.cc
extensions/browser/api/management/management_api.cc
extensions/browser/api/metrics_private/metrics_private_api.cc
extensions/browser/api/networking_private/networking_private_chromeos.cc
extensions/browser/api/socket/socket_api.cc
extensions/browser/api/sockets_tcp/sockets_tcp_api.cc
extensions/browser/api/storage/settings_quota_unittest.cc
extensions/browser/api/storage/storage_api.cc
extensions/browser/api/usb/usb_api.cc
extensions/browser/extension_prefs.cc
extensions/browser/value_store/value_store_frontend_unittest.cc
extensions/common/value_builder.cc
extensions/renderer/argument_spec.cc
headless/public/domains/types_unittest.cc
headless/public/internal/value_conversions.h
ios/chrome/browser/metrics/ios_chrome_metrics_service_accessor_unittest.cc
ios/chrome/browser/passwords/credential_manager_unittest.mm
ios/chrome/browser/ui/webui/crashes_ui.cc
ios/chrome/browser/ui/webui/history/browsing_history_handler.cc
ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc
ios/web/web_state/ui/web_view_js_utils.mm
ios/web/webui/mojo_facade.mm
ipc/ipc_message_unittest.cc
ipc/ipc_message_utils.cc
ipc/ipc_message_utils_unittest.cc
net/log/net_log_unittest.cc
services/preferences/public/cpp/tests/pref_observer_store_unittest.cc
skia/ext/benchmarking_canvas.cc
tools/clang/value_cleanup/ListValueRewriter.cpp
tools/clang/value_cleanup/tests/list-value-append-original.cc
tools/ipc_fuzzer/fuzzer/fuzzer.cc
tools/json_schema_compiler/cc_generator.py
tools/json_schema_compiler/cpp_util.py
tools/json_schema_compiler/test/any_unittest.cc
tools/json_schema_compiler/test/arrays_unittest.cc
tools/json_schema_compiler/test/choices_unittest.cc
tools/json_schema_compiler/test/crossref_unittest.cc
tools/json_schema_compiler/test/error_generation_unittest.cc
tools/json_schema_compiler/test/idl_schemas_unittest.cc
tools/json_schema_compiler/test/objects_unittest.cc
tools/json_schema_compiler/test/simple_api_unittest.cc
tools/win/DebugVisualizers/chrome.natvis
ui/chromeos/network/network_state_notifier_unittest.cc
View side-by-side diff with in-line comments
Download patch
« no previous file with comments
|
« components/ownership/owner_settings_service.cc
('k') |
components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc »
('j') |
no next file with comments »
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
Index: components/password_manager/core/browser/password_manager_metrics_util.cc
diff --git a/components/password_manager/core/browser/password_manager_metrics_util.cc b/components/password_manager/core/browser/password_manager_metrics_util.cc
index b184e6fe7e4d930caad57a3ae327459b9d0c2ae9..ce39db7b5b68855c225a9cd186c8cfb8964ad038 100644
--- a/components/password_manager/core/browser/password_manager_metrics_util.cc
+++ b/components/password_manager/core/browser/password_manager_metrics_util.cc
@@ -18,7 +18,7 @@
#include "url/gurl.h"
using base::ListValue;
-using base::FundamentalValue;
+using base::Value;
namespace password_manager {
« no previous file with comments
|
« components/ownership/owner_settings_service.cc
('k') |
components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc »
('j') |
no next file with comments »
Issue 2476493003: Remove FundamentalValue
Created 4 years, 1 month ago by brettw
Modified 4 years, 1 month ago
Reviewers:
Base URL:
Comments: 0
This is Rietveld
408576698
Chromium Code Reviews
Issue 2476493003:
Remove FundamentalValue
