Roll OpenH264 from v1.4.1 to v1.6.0

Roll OpenH264 from v1.4.1 to v1.6.0

Second take.
Previous attempt (https://codereview.chromium.org/2440143002) caused
quality regressions. sSpatialLayers[0].sSliceArgument.uiSliceNum = 1 is
the workaround for now.

BUG=chromium:614970
Committed: https://crrev.com/3c3e253cdc8ee3cde7b76c80e205eb3f86eae833
Cr-Commit-Position: refs/heads/master@{#430299}

[sprang_chromium, 2016-11-03 13:27:08]

sprang@chromium.org changed reviewers:
+ hbos@chromium.org, mcasas@chromium.org

[sprang_chromium, 2016-11-03 13:27:08]

New attempt. ptal

[hbos_chromium, 2016-11-03 15:13:10]

lgtm

[mcasas, 2016-11-03 15:35:13]

RS lgtm with comments

https://codereview.chromium.org/2475623002/diff/1/content/renderer/media/vide...
File content/renderer/media/video_track_recorder.cc (right):

https://codereview.chromium.org/2475623002/diff/1/content/renderer/media/vide...
content/renderer/media/video_track_recorder.cc:1039: //               when
uiSliceNum > 1.
No need to indent here.

Also, is there a bug we can refer to ?

[sprang_chromium, 2016-11-07 15:47:55]

I couldn't find an existing issue, so filed
https://codereview.chromium.org/2475623002 with openh264.
Shall I file an additional chromium bug to track this?

[sprang_chromium, 2016-11-07 15:48:04]

The CQ bit was checked by sprang@chromium.org

[sprang_chromium, 2016-11-07 15:48:04]

The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org,
hbos@chromium.org
Link to the patchset: https://codereview.chromium.org/2475623002/#ps20001
(title: "Updated comment")

[commit-bot: I haz the power, 2016-11-07 15:48:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-07 17:03:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-11-07 17:13:38]

Description was changed from

==========
Roll OpenH264 from v1.4.1 to v1.6.0

Second take.
Previous attempt (https://codereview.chromium.org/2440143002) caused
quality regressions. sSpatialLayers[0].sSliceArgument.uiSliceNum = 1 is
the workaround for now.

BUG=chromium:614970
==========

to

==========
Roll OpenH264 from v1.4.1 to v1.6.0

Second take.
Previous attempt (https://codereview.chromium.org/2440143002) caused
quality regressions. sSpatialLayers[0].sSliceArgument.uiSliceNum = 1 is
the workaround for now.

BUG=chromium:614970

Committed: https://crrev.com/3c3e253cdc8ee3cde7b76c80e205eb3f86eae833
Cr-Commit-Position: refs/heads/master@{#430299}
==========

[commit-bot: I haz the power, 2016-11-07 17:13:39]

Patchset 2 (id:??) landed as
https://crrev.com/3c3e253cdc8ee3cde7b76c80e205eb3f86eae833
Cr-Commit-Position: refs/heads/master@{#430299}