Roll OpenH264 from v1.4.1 to v1.6.0

Roll OpenH264 from v1.4.1 to v1.6.0

BUG=chromium:614970
Committed: https://crrev.com/ae101afbcb955c6efbbf27bebf81334b95659c11
Cr-Commit-Position: refs/heads/master@{#427688}

[sprang_chromium, 2016-10-21 14:55:53]

sprang@chromium.org changed reviewers:
+ hbos@chromium.org, mcasas@chromium.org

[sprang_chromium, 2016-10-21 14:55:55]

mcasas@, you did the original code in video_track_recorder.cc, can you have a
look?
hbos@ and owner for third_party/openh264
Hwo should I add as owner for DEPS?

[mcasas, 2016-10-21 16:16:38]

On 2016/10/21 14:55:55, sprang_chromium wrote:
> mcasas@, you did the original code in video_track_recorder.cc, can you have a
> look?
> hbos@ and owner for third_party/openh264
> Hwo should I add as owner for DEPS?
see //OWNERS,: 
per-file DEPS=*

so any Cr committer can approve those changes.

Otherwise content/ lgtm if bots are happy.

[hbos_chromium, 2016-10-21 17:33:42]

On 2016/10/21 14:55:55, sprang_chromium wrote:
> mcasas@, you did the original code in video_track_recorder.cc, can you have a
> look?
> hbos@ and owner for third_party/openh264
> Hwo should I add as owner for DEPS?

You don't need anyone for DEPS (per-file DEPS=*).

This is LGTM but you'll have to use the version macros in third_party/webrtc/
and do a roll to make sure this doesn't break webrtc.

[sprang_chromium, 2016-10-21 17:42:47]

Right, thanks.
And yes, I won't try to land this until
https://codereview.chromium.org/2440113002/ has been landed and rolled into
chrome.

[sprang_chromium, 2016-10-25 11:52:48]

Updated CL based on https://codereview.webrtc.org/2440113002
The fallback is only really needed in webrtc since we can't do this update and
roll openh264 in one go there.

[sprang_chromium, 2016-10-26 12:17:26]

The CQ bit was checked by sprang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 12:17:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sprang_chromium, 2016-10-26 12:29:27]

The CQ bit was checked by sprang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 12:29:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 12:54:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 12:54:17]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[sprang_chromium, 2016-10-26 13:29:41]

You may want to take another pass.

Seems the default complexity setting has changed from medium to low, so I now
explicitly set it to medium instead of DCHECKing. Is that what we want?
Changed here:
https://github.com/cisco/openh264/commit/3dff262fe7c9b260d9cb3fd20e10cb9ab326...

[sprang_chromium, 2016-10-26 13:29:51]

The CQ bit was checked by sprang@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 13:30:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hbos_chromium, 2016-10-26 13:35:44]

lgtm

[commit-bot: I haz the power, 2016-10-26 14:25:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 14:25:20]

Dry run: This issue passed the CQ dry run.

[sprang_chromium, 2016-10-26 14:34:46]

The CQ bit was checked by sprang@chromium.org

[sprang_chromium, 2016-10-26 14:34:46]

The patchset sent to the CQ was uploaded after l-g-t-m from mcasas@chromium.org
Link to the patchset: https://codereview.chromium.org/2440143002/#ps80001
(title: "Use medium complexity setting")

[commit-bot: I haz the power, 2016-10-26 14:35:03]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 14:39:38]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-10-26 14:41:28]

Description was changed from

==========
Roll OpenH264 from v1.4.1 to v1.6.0

BUG=chromium:614970
==========

to

==========
Roll OpenH264 from v1.4.1 to v1.6.0

BUG=chromium:614970

Committed: https://crrev.com/ae101afbcb955c6efbbf27bebf81334b95659c11
Cr-Commit-Position: refs/heads/master@{#427688}
==========

[commit-bot: I haz the power, 2016-10-26 14:41:30]

Patchset 5 (id:??) landed as
https://crrev.com/ae101afbcb955c6efbbf27bebf81334b95659c11
Cr-Commit-Position: refs/heads/master@{#427688}

[sprang_chromium, 2016-10-27 10:39:32]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2459503002/ by sprang@chromium.org.

The reason for reverting is: Causing perf regression in webrtc..