Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.h

Issue 2475443003: Drag-and-drop: Move startDrag out of WebView/RenderView. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebViewImpl.h
diff --git a/third_party/WebKit/Source/web/WebViewImpl.h b/third_party/WebKit/Source/web/WebViewImpl.h
index 5f78c91f552ae4dfbe5d8a63e40aecac4ae47a1f..b910c465eea4d63d09b74bddbd9f0984d417b718 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.h
+++ b/third_party/WebKit/Source/web/WebViewImpl.h
@@ -389,13 +389,6 @@ class WEB_EXPORT WebViewImpl final
void updateMainFrameLayoutSize();
void updatePageDefinedViewportConstraints(const ViewportDescription&);
- // Start a system drag and drop operation.
- void startDragging(LocalFrame*,
- const WebDragData& dragData,
- WebDragOperationsMask mask,
- const WebImage& dragImage,
- const WebPoint& dragImageOffset);
-
PagePopup* openPagePopup(PagePopupClient*);
void closePagePopup(PagePopup*);
void cleanupPagePopup();
@@ -511,6 +504,10 @@ class WEB_EXPORT WebViewImpl final
ChromeClientImpl& chromeClient() const { return *m_chromeClientImpl.get(); }
+ // TODO(paulmeyer): Move this to WebWidget once all drag-and-drop functions
+ // are there.
+ bool m_doingDragAndDrop;
dcheng 2016/11/03 21:22:52 Let's add a setter for this instead of directly ma
paulmeyer 2016/11/04 19:01:18 Done.
+
private:
InspectorOverlay* inspectorOverlay();
@@ -669,8 +666,6 @@ class WEB_EXPORT WebViewImpl final
float m_fakePageScaleAnimationPageScaleFactor;
bool m_fakePageScaleAnimationUseAnchor;
- bool m_doingDragAndDrop;
-
bool m_ignoreInputEvents;
float m_compositorDeviceScaleFactorOverride;

Powered by Google App Engine
This is Rietveld 408576698