Drag-and-drop: Move startDrag out of WebView/RenderView.

third_party/WebKit/Source/web/WebViewImpl.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 371 matching lines @@
 
   bool shouldAutoResize() const { return m_shouldAutoResize; }
 
   IntSize minAutoSize() const { return m_minAutoSize; }
 
   IntSize maxAutoSize() const { return m_maxAutoSize; }
 
   void updateMainFrameLayoutSize();
   void updatePageDefinedViewportConstraints(const ViewportDescription&);
 
-  // Start a system drag and drop operation.
-  void startDragging(LocalFrame*,
-                     const WebDragData& dragData,
-                     WebDragOperationsMask mask,
-                     const WebImage& dragImage,
-                     const WebPoint& dragImageOffset);
-
   PagePopup* openPagePopup(PagePopupClient*);
   void closePagePopup(PagePopup*);
   void cleanupPagePopup();
   LocalDOMWindow* pagePopupWindow() const;
 
   // Returns the input event we're currently processing. This is used in some
   // cases where the WebCore DOM event doesn't have the information we need.
   static const WebInputEvent* currentInputEvent() {
     return m_currentInputEvent;
   }
@@ skipping 95 matching lines @@
 
   FloatSize elasticOverscroll() const { return m_elasticOverscroll; }
 
   bool isTransparent() const;
   void setIsTransparent(bool value);
 
   double lastFrameTimeMonotonic() const { return m_lastFrameTimeMonotonic; }
 
   ChromeClientImpl& chromeClient() const { return *m_chromeClientImpl.get(); }
 
+  // TODO(paulmeyer): Move this to WebWidget once all drag-and-drop functions
+  // are there.
+  bool m_doingDragAndDrop;

[dcheng, 2016/11/03 21:22:52]

Let's add a setter for this instead of directly manipulating it from another
class.

[paulmeyer, 2016/11/04 19:01:18]

Done.

+
  private:
   InspectorOverlay* inspectorOverlay();
 
   void setPageScaleFactorAndLocation(float, const FloatPoint&);
   void propagateZoomFactorToLocalFrameRoots(Frame*, float);
 
   void scrollAndRescaleViewports(float scaleFactor,
                                  const IntPoint& mainFrameOrigin,
                                  const FloatPoint& visualViewportOrigin);
 
@@ skipping 138 matching lines @@
   float m_doubleTapZoomPageScaleFactor;
   // Have we sent a double-tap zoom and not yet heard back the scale?
   bool m_doubleTapZoomPending;
 
   // Used for testing purposes.
   bool m_enableFakePageScaleAnimationForTesting;
   IntPoint m_fakePageScaleAnimationTargetPosition;
   float m_fakePageScaleAnimationPageScaleFactor;
   bool m_fakePageScaleAnimationUseAnchor;
 
-  bool m_doingDragAndDrop;
-
   bool m_ignoreInputEvents;
 
   float m_compositorDeviceScaleFactorOverride;
   TransformationMatrix m_deviceEmulationTransform;
 
   // Webkit expects keyPress events to be suppressed if the associated keyDown
   // event was handled. Safari implements this behavior by peeking out the
   // associated WM_CHAR event if the keydown was handled. We emulate
   // this behavior by setting this flag if the keyDown was handled.
   bool m_suppressNextKeypressEvent;
@@ skipping 78 matching lines @@
   Persistent<ResizeViewportAnchor> m_resizeViewportAnchor;
 };
 
 // We have no ways to check if the specified WebView is an instance of
 // WebViewImpl because WebViewImpl is the only implementation of WebView.
 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
 
 }  // namespace blink
 
 #endif