Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(336)

Unified Diff: third_party/WebKit/Source/web/WebViewImpl.cpp

Issue 2475443003: Drag-and-drop: Move startDrag out of WebView/RenderView. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebViewImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebViewImpl.cpp b/third_party/WebKit/Source/web/WebViewImpl.cpp
index 9faff29cc1d9fd8146e0e7018a8816800c5b7f8c..cf006431ce693d44f9ce0091bcf4f7813ec332f2 100644
--- a/third_party/WebKit/Source/web/WebViewImpl.cpp
+++ b/third_party/WebKit/Source/web/WebViewImpl.cpp
@@ -386,7 +386,8 @@ HashSet<WebViewImpl*>& WebViewImpl::allInstances() {
WebViewImpl::WebViewImpl(WebViewClient* client,
WebPageVisibilityState visibilityState)
- : m_client(client),
+ : m_doingDragAndDrop(false),
+ m_client(client),
m_spellCheckClient(nullptr),
m_chromeClientImpl(ChromeClientImpl::create(this)),
m_contextMenuClientImpl(this),
@@ -404,7 +405,6 @@ WebViewImpl::WebViewImpl(WebViewClient* client,
m_enableFakePageScaleAnimationForTesting(false),
m_fakePageScaleAnimationPageScaleFactor(0),
m_fakePageScaleAnimationUseAnchor(false),
- m_doingDragAndDrop(false),
m_ignoreInputEvents(false),
m_compositorDeviceScaleFactorOverride(0),
m_suppressNextKeypressEvent(false),
@@ -3944,19 +3944,6 @@ bool WebViewImpl::useExternalPopupMenus() {
return shouldUseExternalPopupMenus;
}
-void WebViewImpl::startDragging(LocalFrame* frame,
- const WebDragData& dragData,
- WebDragOperationsMask mask,
- const WebImage& dragImage,
- const WebPoint& dragImageOffset) {
- if (!m_client)
- return;
- DCHECK(!m_doingDragAndDrop);
- m_doingDragAndDrop = true;
- m_client->startDragging(WebLocalFrameImpl::fromFrame(frame), dragData, mask,
- dragImage, dragImageOffset);
-}
-
void WebViewImpl::setIgnoreInputEvents(bool newValue) {
DCHECK_NE(m_ignoreInputEvents, newValue);
m_ignoreInputEvents = newValue;

Powered by Google App Engine
This is Rietveld 408576698