third_party/WebKit/LayoutTests/fragmentation/overhanging-float-change-fragmentainer-height.html - Issue 2474883002: logicalHeightWithVisibleOverflow() needs to include overhanging floats.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fragmentation/overhanging-float-change-fragmentainer-height.html

Issue 2474883002: logicalHeightWithVisibleOverflow() needs to include overhanging floats. (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/fragmentation/overhanging-float-change-fragmentainer-height.html

diff --git a/third_party/WebKit/LayoutTests/fast/multicol/balance-float-with-margin-top-and-line-before-break.html b/third_party/WebKit/LayoutTests/fragmentation/overhanging-float-change-fragmentainer-height.html

similarity index 54%

copy from third_party/WebKit/LayoutTests/fast/multicol/balance-float-with-margin-top-and-line-before-break.html

copy to third_party/WebKit/LayoutTests/fragmentation/overhanging-float-change-fragmentainer-height.html

index 1e0c5244a02add541c0a9d367a516d4dc60d9d74..e6c767ea9bd14878f8600cf12eeabf09fe834e03 100644

--- a/third_party/WebKit/LayoutTests/fast/multicol/balance-float-with-margin-top-and-line-before-break.html

+++ b/third_party/WebKit/LayoutTests/fragmentation/overhanging-float-change-fragmentainer-height.html

@@ -1,22 +1,27 @@

<!DOCTYPE html>

<p>There should be a blue rectangle in the bottom left corner of a yellow rectangle.</p>

-<div id="multicol" style="position:relative; width:70px; columns:2; line-height:20px; background:yellow;">

+<div id="multicol" style="position:relative; width:70px; columns:2; column-fill:auto; height:50px; line-height:20px; background:yellow;">

<br>

- <div id="elm" style="float:left; width:20px; margin-top:10px; background:blue;"><br></div>

+ <div>

+ <div id="elm" style="float:left; width:20px; background:blue;"><br></div>

+ </div>

<br>

</div>

-<script src="../../resources/testharness.js"></script>

-<script src="../../resources/testharnessreport.js"></script>

+<script src="../resources/testharness.js"></script>

+<script src="../resources/testharnessreport.js"></script>

test(() => {

var multicol = document.getElementById("multicol");

var elm = document.getElementById("elm");

- assert_equals(multicol.offsetHeight, 70);

- assert_equals(elm.offsetTop, 50);

+ document.body.offsetTop;

+ multicol.style.height = "60px";

+ assert_equals(elm.offsetTop, 40);

assert_equals(elm.offsetHeight, 20);

}, "Float that should fit at the bottom of the first column.");

</script>

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlockFlow.h » ('j') | no next file with comments »