Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 2474863004: bluetooth: Add characteristics to the device's attribute instance map (Closed)

Created:
4 years, 1 month ago by ortuno
Modified:
4 years, 1 month ago
Reviewers:
scheib
CC:
blink-reviews, chromium-reviews, haraken, ortuno+watch_chromium.org, scheib+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth: Add characteristics to the device's attribute instance map Results in multiple calls to getCharacteristic(s) to return the same object. BUG=495270 Committed: https://crrev.com/4eee6eb0a780aa2b6b12f946a937f3f802c7126c Cr-Commit-Position: refs/heads/master@{#430207}

Patch Set 1 #

Patch Set 2 : Merge branch 'bluetooth-invalidate-service' into bluetooth-attribute-chars #

Patch Set 3 : clean up #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -73 lines) Patch
A third_party/WebKit/LayoutTests/bluetooth/getCharacteristic/gen-characteristic-get-same-object.html View 1 chunk +36 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/getCharacteristic/get-same-characteristic.html View 1 chunk +0 lines, -28 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/gen-characteristic-get-same-object.html View 1 chunk +36 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/gen-characteristic-get-same-object-with-uuid.html View 1 chunk +36 lines, -0 lines 0 comments Download
D third_party/WebKit/LayoutTests/bluetooth/getCharacteristics/get-same-characteristics.html View 1 chunk +0 lines, -28 lines 0 comments Download
A third_party/WebKit/LayoutTests/bluetooth/script-tests/characteristic-get-same-object.js View 1 chunk +31 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.h View 4 chunks +17 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothAttributeInstanceMap.cpp View 3 chunks +21 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.h View 1 2 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp View 2 chunks +6 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTService.cpp View 2 chunks +8 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 20 (15 generated)
ortuno
scheib: PTAL
4 years, 1 month ago (2016-11-04 05:30:33 UTC) #5
scheib
LGTM
4 years, 1 month ago (2016-11-04 23:09:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2474863004/40001
4 years, 1 month ago (2016-11-07 01:29:14 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-11-07 01:33:10 UTC) #18
commit-bot: I haz the power
4 years, 1 month ago (2016-11-07 01:39:52 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4eee6eb0a780aa2b6b12f946a937f3f802c7126c
Cr-Commit-Position: refs/heads/master@{#430207}

Powered by Google App Engine
This is Rietveld 408576698