third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h - Issue 2474863004: bluetooth: Add characteristics to the device's attribute instance map

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h

Issue 2474863004: bluetooth: Add characteristics to the device's attribute instance map (Closed)

Patch Set: clean up Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/bluetooth/BluetoothDevice.cpp ('k') | third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h

diff --git a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h

index 6b9df6ddb395bdd2f698fd4e030bf23b935256f9..1dcdad97f09bfbb68f4c50428628475b6cc37f71 100644

--- a/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h

+++ b/third_party/WebKit/Source/modules/bluetooth/BluetoothRemoteGATTCharacteristic.h

@@ -47,10 +47,8 @@ class BluetoothRemoteGATTCharacteristic final

std::unique_ptr<WebBluetoothRemoteGATTCharacteristicInit>,

BluetoothRemoteGATTService*);

- // Interface required by CallbackPromiseAdapter.

- using WebType = std::unique_ptr<WebBluetoothRemoteGATTCharacteristicInit>;

- static BluetoothRemoteGATTCharacteristic* take(

- ScriptPromiseResolver*,

+ static BluetoothRemoteGATTCharacteristic* create(

+ ExecutionContext*,

std::unique_ptr<WebBluetoothRemoteGATTCharacteristicInit>,

BluetoothRemoteGATTService*);