bluetooth: Invalidate characteristics when disconnecting

bluetooth: Invalidate characteristics when disconnecting

Remove characteristics from attribute instance map when a device
disconnects or when disconnect is called. Check that the
characteristic is in the attribute instance map and reject if it isn't.

BUG=654950
Committed: https://crrev.com/35b0cbff31387ff3b69607850f5ccfe99e2d4817
Cr-Commit-Position: refs/heads/master@{#430788}

[ortuno, 2016-11-06 23:49:24]

The CQ bit was checked by ortuno@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-06 23:49:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ortuno, 2016-11-07 00:36:00]

ortuno@chromium.org changed reviewers:
+ scheib@chromium.org

[ortuno, 2016-11-07 00:36:01]

scheib: PTAL

[commit-bot: I haz the power, 2016-11-07 01:39:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-07 01:39:20]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[scheib, 2016-11-08 01:44:26]

LGTM

https://codereview.chromium.org/2476173002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/bluetooth/gattserverdisconnected-event/reconnect-during-disconnected-event.html
(right):

https://codereview.chromium.org/2476173002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/bluetooth/gattserverdisconnected-event/reconnect-during-disconnected-event.html:18:
let reconnection = new Promise(resolve => {
name suggestions?

s/reconnection/waitUntilReconnection/

https://codereview.chromium.org/2476173002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/bluetooth/gattserverdisconnected-event/reconnect-during-disconnected-event.html:19:
let wrapper = function(event) {
s/wrapper/reconnectThenResolve/ ?

[ortuno, 2016-11-08 04:51:47]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2016-11-08 04:51:48]

Thanks!

https://codereview.chromium.org/2476173002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/bluetooth/gattserverdisconnected-event/reconnect-during-disconnected-event.html
(right):

https://codereview.chromium.org/2476173002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/bluetooth/gattserverdisconnected-event/reconnect-during-disconnected-event.html:18:
let reconnection = new Promise(resolve => {
On 2016/11/08 at 01:44:26, scheib wrote:
> name suggestions?
> 
> s/reconnection/waitUntilReconnection/

Done.

https://codereview.chromium.org/2476173002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/bluetooth/gattserverdisconnected-event/reconnect-during-disconnected-event.html:19:
let wrapper = function(event) {
On 2016/11/08 at 01:44:26, scheib wrote:
> s/wrapper/reconnectThenResolve/ ?

Done.

[ortuno, 2016-11-08 04:51:48]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/2476173002/#ps20001
(title: "Improve names")

[commit-bot: I haz the power, 2016-11-08 04:51:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-08 07:25:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-08 07:25:03]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[ortuno, 2016-11-08 22:26:27]

The CQ bit was checked by ortuno@chromium.org

[ortuno, 2016-11-08 22:26:28]

The patchset sent to the CQ was uploaded after l-g-t-m from scheib@chromium.org
Link to the patchset: https://codereview.chromium.org/2476173002/#ps40001
(title: "Fix test expectations")

[commit-bot: I haz the power, 2016-11-08 22:27:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-09 00:27:30]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-09 00:35:39]

Description was changed from

==========
bluetooth: Invalidate characteristics when disconnecting

Remove characteristics from attribute instance map when a device
disconnects or when disconnect is called. Check that the
characteristic is in the attribute instance map and reject if it isn't.

BUG=654950
==========

to

==========
bluetooth: Invalidate characteristics when disconnecting

Remove characteristics from attribute instance map when a device
disconnects or when disconnect is called. Check that the
characteristic is in the attribute instance map and reject if it isn't.

BUG=654950

Committed: https://crrev.com/35b0cbff31387ff3b69607850f5ccfe99e2d4817
Cr-Commit-Position: refs/heads/master@{#430788}
==========

[commit-bot: I haz the power, 2016-11-09 00:35:40]

Patchset 3 (id:??) landed as
https://crrev.com/35b0cbff31387ff3b69607850f5ccfe99e2d4817
Cr-Commit-Position: refs/heads/master@{#430788}