Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: third_party/WebKit/Source/core/page/FocusController.cpp

Issue 2474323002: Implement WebContentsViewChildFrame::TakeFocus. (Closed)
Patch Set: Conflicted with my own cl https://codereview.chromium.org/2455133005/ Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/FocusController.cpp
diff --git a/third_party/WebKit/Source/core/page/FocusController.cpp b/third_party/WebKit/Source/core/page/FocusController.cpp
index e9723e85639f74c9dd7331209e829670966c32b4..d11fd62a3e32e75452a98c6ef50b93edbb9df069 100644
--- a/third_party/WebKit/Source/core/page/FocusController.cpp
+++ b/third_party/WebKit/Source/core/page/FocusController.cpp
@@ -874,7 +874,7 @@ void FocusController::setFocused(bool focused) {
if (!m_isFocused && focusedOrMainFrame()->isLocalFrame())
toLocalFrame(focusedOrMainFrame())->eventHandler().stopAutoscroll();
- if (!m_focusedFrame)
+ if (!m_focusedFrame && m_isFocused)
alexmos 2016/11/22 02:45:27 Why is this needed? How is it related to the rest
avallee 2016/11/25 19:39:54 When you call Blur on a page with no focused frame
alexmos 2016/11/28 23:52:24 In what scenario would that happen during tab trav
avallee 2016/12/09 21:16:51 When we reach the end of the guest focusable eleme
alexmos 2016/12/12 22:41:15 Acknowledged. I didn't realize that the TakeFocus
setFocusedFrame(m_page->mainFrame());
// setFocusedFrame above might reject to update m_focusedFrame, or

Powered by Google App Engine
This is Rietveld 408576698