Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(723)

Unified Diff: content/browser/web_contents/web_contents_view_guest.cc

Issue 2474323002: Implement WebContentsViewChildFrame::TakeFocus. (Closed)
Patch Set: Conflicted with my own cl https://codereview.chromium.org/2455133005/ Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_contents_view_guest.cc
diff --git a/content/browser/web_contents/web_contents_view_guest.cc b/content/browser/web_contents/web_contents_view_guest.cc
index b2b86fa755e42097b0fedadd693a32b281cd57be..0fa2591ada56a604829a58e1dc83aaca0c9dfbc9 100644
--- a/content/browser/web_contents/web_contents_view_guest.cc
+++ b/content/browser/web_contents/web_contents_view_guest.cc
@@ -217,6 +217,7 @@ void WebContentsViewGuest::GotFocus() {
}
void WebContentsViewGuest::TakeFocus(bool reverse) {
+ LOG(ERROR) << this << "WebContentsViewChildFrame::TakeFocus: " << reverse;
alexmos 2016/11/22 02:45:27 Don't forget to remove. And by the way, does the
avallee 2016/11/25 19:39:54 No, ViewHostMsg_TakeFocus is handled by BrowserPlu
alexmos 2016/11/28 23:52:23 Acknowledged.
}
void WebContentsViewGuest::ShowContextMenu(RenderFrameHost* render_frame_host,

Powered by Google App Engine
This is Rietveld 408576698