Implement WebContentsViewChildFrame::TakeFocus.

third_party/WebKit/Source/core/page/FocusController.cpp

 /*
  * Copyright (C) 2006, 2007 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nuanti Ltd.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 856 matching lines @@
 
 void FocusController::setFocused(bool focused) {
   if (isFocused() == focused)
     return;
 
   m_isFocused = focused;
 
   if (!m_isFocused && focusedOrMainFrame()->isLocalFrame())
     toLocalFrame(focusedOrMainFrame())->eventHandler().stopAutoscroll();
 
-  if (!m_focusedFrame)
+  if (!m_focusedFrame && m_isFocused)

[alexmos, 2016/11/22 02:45:27]

Why is this needed?  How is it related to the rest of this CL?  If it's needed,
can you add a comment?

[avallee, 2016/11/25 19:39:54]

When you call Blur on a page with no focused frame, this ends up focusing a
frame and sending back an IPC that steals focus.

[alexmos, 2016/11/28 23:52:24]

In what scenario would that happen during tab traversal?  I thought we got rid
of unsetting the focused frame in https://codereview.chromium.org/2451143003/,
so then is this only happening when blurring a WebContents on which you've never
clicked (which thus has no focused frame to start with)?

[avallee, 2016/12/09 21:16:51]

When we reach the end of the guest focusable elements we ask our embedder to
TakeFocus after clearing the focused element and  focused frame:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/page/Focu...

As part of taking focus from the guest we blur the widget in which case we
arrive here  with no focused frame and isFocused false.

[alexmos, 2016/12/12 22:41:15]

Acknowledged.  I didn't realize that the TakeFocus path clears the focused
frame.

     setFocusedFrame(m_page->mainFrame());
 
   // setFocusedFrame above might reject to update m_focusedFrame, or
   // m_focusedFrame might be changed by blur/focus event handlers.
   if (m_focusedFrame && m_focusedFrame->isLocalFrame() &&
       toLocalFrame(m_focusedFrame.get())->view()) {
     toLocalFrame(m_focusedFrame.get())->selection().setFocused(focused);
     dispatchEventsOnWindowAndFocusedElement(
         toLocalFrame(m_focusedFrame.get())->document(), focused);
   }
@@ skipping 523 matching lines @@
 
   return consumed;
 }
 
 DEFINE_TRACE(FocusController) {
   visitor->trace(m_page);
   visitor->trace(m_focusedFrame);
 }
 
 }  // namespace blink