Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Unified Diff: third_party/WebKit/Source/core/events/EventTarget.cpp

Issue 2474073005: DevTools: add the logging aspect into the PerformanceMonitor (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/events/EventTarget.cpp
diff --git a/third_party/WebKit/Source/core/events/EventTarget.cpp b/third_party/WebKit/Source/core/events/EventTarget.cpp
index bf5009de7b46e88c1ba45e3c181be43731e6a241..0581ddd3a0c5ba723e374f3e36df55e0880b67e7 100644
--- a/third_party/WebKit/Source/core/events/EventTarget.cpp
+++ b/third_party/WebKit/Source/core/events/EventTarget.cpp
@@ -42,9 +42,9 @@
#include "core/events/PointerEvent.h"
#include "core/frame/FrameHost.h"
#include "core/frame/LocalDOMWindow.h"
+#include "core/frame/PerformanceMonitor.h"
#include "core/frame/Settings.h"
#include "core/frame/UseCounter.h"
-#include "core/inspector/ConsoleMessage.h"
#include "core/inspector/InspectorInstrumentation.h"
#include "platform/EventDispatchForbiddenScope.h"
#include "platform/Histogram.h"
@@ -137,10 +137,7 @@ void reportBlockedEvent(ExecutionContext* context,
eventListenerEffectiveFunction(v8Listener->isolate(), handler);
std::unique_ptr<SourceLocation> location =
SourceLocation::fromFunction(function);
- ConsoleMessage* message = ConsoleMessage::create(
- JSMessageSource, WarningMessageLevel, messageText, std::move(location));
- context->addConsoleMessage(message);
- registeredListener->setBlockedEventWarningEmitted();
caseq 2016/11/04 20:58:59 Bring this back, we really need it!
pfeldman 2016/11/04 21:26:39 Ouch, thank you.
+ PerformanceMonitor::logViolation(context, messageText, std::move(location));
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698