Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: third_party/WebKit/Source/core/frame/FrameView.cpp

Issue 2474073005: DevTools: add the logging aspect into the PerformanceMonitor (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/FrameView.cpp
diff --git a/third_party/WebKit/Source/core/frame/FrameView.cpp b/third_party/WebKit/Source/core/frame/FrameView.cpp
index c409f3dd70a264554619e32d09f43914f48d7461..598e169a31bf24b0bb35264109462c5ef4347631 100644
--- a/third_party/WebKit/Source/core/frame/FrameView.cpp
+++ b/third_party/WebKit/Source/core/frame/FrameView.cpp
@@ -50,6 +50,7 @@
#include "core/frame/LocalFrame.h"
#include "core/frame/Location.h"
#include "core/frame/PageScaleConstraintsSet.h"
+#include "core/frame/PerformanceMonitor.h"
#include "core/frame/Settings.h"
#include "core/frame/VisualViewport.h"
#include "core/html/HTMLFrameElement.h"
@@ -1089,13 +1090,13 @@ void FrameView::layout() {
DocumentLifecycle::Scope lifecycleScope(lifecycle(),
DocumentLifecycle::LayoutClean);
+ Document* document = m_frame->document();
TRACE_EVENT_BEGIN1("devtools.timeline", "Layout", "beginData",
InspectorLayoutEvent::beginData(this));
+ PerformanceMonitor::willUpdateLayout(document);
performPreLayoutTasks();
- Document* document = m_frame->document();
-
// TODO(crbug.com/460956): The notion of a single root for layout is no longer
// applicable. Remove or update this code.
LayoutObject* rootForThisLayout = layoutView();
@@ -1236,6 +1237,7 @@ void FrameView::layout() {
TRACE_EVENT_END1("devtools.timeline", "Layout", "endData",
InspectorLayoutEvent::endData(rootForThisLayout));
InspectorInstrumentation::didUpdateLayout(m_frame.get());
+ PerformanceMonitor::didUpdateLayout(document);
m_nestedLayoutCount--;
if (m_nestedLayoutCount)

Powered by Google App Engine
This is Rietveld 408576698