DevTools: add the logging aspect into the PerformanceMonitor

third_party/WebKit/Source/core/events/EventTarget.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  *           (C) 2007, 2008 Nikolas Zimmermann <zimmermann@kde.org>
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
@@ skipping 24 matching lines @@
 #include "bindings/core/v8/ScriptEventListener.h"
 #include "bindings/core/v8/SourceLocation.h"
 #include "bindings/core/v8/V8DOMActivityLogger.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/editing/Editor.h"
 #include "core/events/Event.h"
 #include "core/events/EventUtil.h"
 #include "core/events/PointerEvent.h"
 #include "core/frame/FrameHost.h"
 #include "core/frame/LocalDOMWindow.h"
+#include "core/frame/PerformanceMonitor.h"
 #include "core/frame/Settings.h"
 #include "core/frame/UseCounter.h"
-#include "core/inspector/ConsoleMessage.h"
 #include "core/inspector/InspectorInstrumentation.h"
 #include "platform/EventDispatchForbiddenScope.h"
 #include "platform/Histogram.h"
 #include "wtf/PtrUtil.h"
 #include "wtf/StdLibExtras.h"
 #include "wtf/Threading.h"
 #include "wtf/Vector.h"
 #include <memory>
 
 using namespace WTF;
@@ skipping 72 matching lines @@
       "Handling of '%s' input event was delayed for %ld ms due to main thread "
       "being busy. "
       "Consider marking event handler as 'passive' to make the page more "
       "responsive.",
       event->type().getString().utf8().data(), lround(delayedSeconds * 1000));
 
   v8::Local<v8::Function> function =
       eventListenerEffectiveFunction(v8Listener->isolate(), handler);
   std::unique_ptr<SourceLocation> location =
       SourceLocation::fromFunction(function);
-  ConsoleMessage* message = ConsoleMessage::create(
-      JSMessageSource, WarningMessageLevel, messageText, std::move(location));
-  context->addConsoleMessage(message);
-  registeredListener->setBlockedEventWarningEmitted();

[caseq, 2016/11/04 20:58:59]

Bring this back, we really need it!

[pfeldman, 2016/11/04 21:26:39]

Ouch, thank you.

+  PerformanceMonitor::logViolation(context, messageText, std::move(location));
 }
 
 }  // namespace
 
 EventTargetData::EventTargetData() {}
 
 EventTargetData::~EventTargetData() {}
 
 DEFINE_TRACE(EventTargetData) {
   visitor->trace(eventListenerMap);
@@ skipping 605 matching lines @@
   // they have one less listener to invoke.
   if (d->firingEventIterators) {
     for (size_t i = 0; i < d->firingEventIterators->size(); ++i) {
       d->firingEventIterators->at(i).iterator = 0;
       d->firingEventIterators->at(i).end = 0;
     }
   }
 }
 
 }  // namespace blink