Enable downloads UI for NTP-saved pages.

Enable downloads UI for NTP-saved pages.

This patch fixes 3 problems:
* The NTP code is gated on a flag in offline pages that is only for
  testing.
* The NTP namespace is marked as "Supported by Download", which allows
  the download home to show these pages, and the download notification
  to work for these pages.

BUG=662105
Committed: https://crrev.com/b637ece132d7e0a975f0780724f8354297552fcd
Cr-Commit-Position: refs/heads/master@{#429727}

[dewittj, 2016-11-03 18:19:08]

The CQ bit was checked by dewittj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 18:19:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dewittj, 2016-11-03 18:23:50]

Description was changed from

==========
Enable downloads UI for NTP-saved pages.

BUG=
==========

to

==========
Enable downloads UI for NTP-saved pages.

This patch fixes 3 problems:
* The NTP code is gated on a flag in offline pages that is only for
  testing.
* The NTP namespace is marked as "Supported by Download", which allows
  the download home to show these pages, and the download notification
  to work for these pages.
* Expands the scope of the overwrite infobar to look for pages in any
  download-supported namespace, not just |kDownloadNmaespace|.

BUG=662105
==========

[dewittj, 2016-11-03 18:23:50]

dewittj@chromium.org changed reviewers:
+ dgn@chromium.org, dimich@chromium.org, vitaliii@chromium.org

[commit-bot: I haz the power, 2016-11-03 18:33:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 18:33:41]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[dewittj, 2016-11-03 20:00:32]

The CQ bit was checked by dewittj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-03 20:01:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dewittj, 2016-11-03 20:01:28]

Patchset #2 (id:10001) has been deleted

[dewittj, 2016-11-03 20:02:04]

ptal, thanks!

[vitaliii, 2016-11-03 21:41:17]

https://codereview.chromium.org/2473953006/diff/30001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java
(left):

https://codereview.chromium.org/2473953006/diff/30001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java:23:
&& OfflinePageBridge.isBackgroundLoadingEnabled();
Justin, could you elaborate on this flag?
Unfortunately, the descriptions of offline pages flags are fairly vague for me,
so before I thought that BackgroundLoading was essential for offlining pages,
but now I am just confused.

[dewittj, 2016-11-03 22:19:37]

https://codereview.chromium.org/2473953006/diff/30001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java
(left):

https://codereview.chromium.org/2473953006/diff/30001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java:23:
&& OfflinePageBridge.isBackgroundLoadingEnabled();
On 2016/11/03 21:41:17, vitaliii wrote:
> Justin, could you elaborate on this flag?
> Unfortunately, the descriptions of offline pages flags are fairly vague for
me,
> so before I thought that BackgroundLoading was essential for offlining pages,
> but now I am just confused.

Sure, this flag is only to enable the *test only* context menu item for saving
pages in the background.

I think you are possibly confused because a while ago we changed around our flag
setup; now we gate features, and all the infrastructure is created on demand
based on which features actually use us.  So everything should *just work* if
you call the offline pages APIs that you need, without special flags.

[vitaliii, 2016-11-03 22:25:07]

Thanks, Justin!

LGTM

[dgn, 2016-11-03 22:26:00]

SnippetsConfig.java lgtm. But as Vitalii said, it would be nice to have more
details in the description of the flags too.

[dewittj, 2016-11-03 22:29:39]

Description was changed from

==========
Enable downloads UI for NTP-saved pages.

This patch fixes 3 problems:
* The NTP code is gated on a flag in offline pages that is only for
  testing.
* The NTP namespace is marked as "Supported by Download", which allows
  the download home to show these pages, and the download notification
  to work for these pages.
* Expands the scope of the overwrite infobar to look for pages in any
  download-supported namespace, not just |kDownloadNmaespace|.

BUG=662105
==========

to

==========
Enable downloads UI for NTP-saved pages.

This patch fixes 3 problems:
* The NTP code is gated on a flag in offline pages that is only for
  testing.
* The NTP namespace is marked as "Supported by Download", which allows
  the download home to show these pages, and the download notification
  to work for these pages.


BUG=662105
==========

[Dmitry Titov, 2016-11-03 22:36:54]

lgtm

[dewittj, 2016-11-03 22:39:14]

The CQ bit was unchecked by dewittj@chromium.org

[dewittj, 2016-11-03 22:39:24]

The CQ bit was checked by dewittj@chromium.org

[commit-bot: I haz the power, 2016-11-03 22:40:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dewittj, 2016-11-03 23:07:25]

btw, I completely agree that the name of that flag is horrible.  Fixing it in an
upcoming CL.

[commit-bot: I haz the power, 2016-11-03 23:36:45]

Description was changed from

==========
Enable downloads UI for NTP-saved pages.

This patch fixes 3 problems:
* The NTP code is gated on a flag in offline pages that is only for
  testing.
* The NTP namespace is marked as "Supported by Download", which allows
  the download home to show these pages, and the download notification
  to work for these pages.


BUG=662105
==========

to

==========
Enable downloads UI for NTP-saved pages.

This patch fixes 3 problems:
* The NTP code is gated on a flag in offline pages that is only for
  testing.
* The NTP namespace is marked as "Supported by Download", which allows
  the download home to show these pages, and the download notification
  to work for these pages.


BUG=662105
==========

[commit-bot: I haz the power, 2016-11-03 23:36:46]

Committed patchset #2 (id:30001)

[commit-bot: I haz the power, 2016-11-03 23:38:32]

Description was changed from

==========
Enable downloads UI for NTP-saved pages.

This patch fixes 3 problems:
* The NTP code is gated on a flag in offline pages that is only for
  testing.
* The NTP namespace is marked as "Supported by Download", which allows
  the download home to show these pages, and the download notification
  to work for these pages.


BUG=662105
==========

to

==========
Enable downloads UI for NTP-saved pages.

This patch fixes 3 problems:
* The NTP code is gated on a flag in offline pages that is only for
  testing.
* The NTP namespace is marked as "Supported by Download", which allows
  the download home to show these pages, and the download notification
  to work for these pages.

BUG=662105

Committed: https://crrev.com/b637ece132d7e0a975f0780724f8354297552fcd
Cr-Commit-Position: refs/heads/master@{#429727}
==========

[commit-bot: I haz the power, 2016-11-03 23:38:33]

Patchset 2 (id:??) landed as
https://crrev.com/b637ece132d7e0a975f0780724f8354297552fcd
Cr-Commit-Position: refs/heads/master@{#429727}