Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 2473953006: Enable downloads UI for NTP-saved pages. (Closed)

Created:
4 years, 1 month ago by dewittj
Modified:
4 years, 1 month ago
Reviewers:
vitaliii, Dmitry Titov, dgn
CC:
chromium-reviews, ntp-dev+reviews_chromium.org, dewittj+watch_chromium.org, fgorski+watch_chromium.org, romax+watch_chromium.org, petewil+watch_chromium.org, chili+watch_chromium.org, agrieve+watch_chromium.org, dimich+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable downloads UI for NTP-saved pages. This patch fixes 3 problems: * The NTP code is gated on a flag in offline pages that is only for testing. * The NTP namespace is marked as "Supported by Download", which allows the download home to show these pages, and the download notification to work for these pages. BUG=662105 Committed: https://crrev.com/b637ece132d7e0a975f0780724f8354297552fcd Cr-Commit-Position: refs/heads/master@{#429727}

Patch Set 1 #

Patch Set 2 : Tests now pass. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -7 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java View 2 chunks +1 line, -3 lines 2 comments Download
M components/offline_pages/client_policy_controller.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/offline_pages/client_policy_controller_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M components/offline_pages/downloads/download_notifying_observer_unittest.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 24 (14 generated)
dewittj
ptal, thanks!
4 years, 1 month ago (2016-11-03 20:02:04 UTC) #10
vitaliii
https://codereview.chromium.org/2473953006/diff/30001/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java (left): https://codereview.chromium.org/2473953006/diff/30001/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java#oldcode23 chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java:23: && OfflinePageBridge.isBackgroundLoadingEnabled(); Justin, could you elaborate on this flag? ...
4 years, 1 month ago (2016-11-03 21:41:17 UTC) #11
dewittj
https://codereview.chromium.org/2473953006/diff/30001/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java File chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java (left): https://codereview.chromium.org/2473953006/diff/30001/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java#oldcode23 chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java:23: && OfflinePageBridge.isBackgroundLoadingEnabled(); On 2016/11/03 21:41:17, vitaliii wrote: > Justin, ...
4 years, 1 month ago (2016-11-03 22:19:37 UTC) #12
vitaliii
Thanks, Justin! LGTM
4 years, 1 month ago (2016-11-03 22:25:07 UTC) #13
dgn
SnippetsConfig.java lgtm. But as Vitalii said, it would be nice to have more details in ...
4 years, 1 month ago (2016-11-03 22:26:00 UTC) #14
Dmitry Titov
lgtm
4 years, 1 month ago (2016-11-03 22:36:54 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2473953006/30001
4 years, 1 month ago (2016-11-03 22:40:04 UTC) #19
dewittj
btw, I completely agree that the name of that flag is horrible. Fixing it in ...
4 years, 1 month ago (2016-11-03 23:07:25 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:30001)
4 years, 1 month ago (2016-11-03 23:36:46 UTC) #22
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 23:38:33 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b637ece132d7e0a975f0780724f8354297552fcd
Cr-Commit-Position: refs/heads/master@{#429727}

Powered by Google App Engine
This is Rietveld 408576698