components/offline_pages/client_policy_controller_unittest.cc - Issue 2473953006: Enable downloads UI for NTP-saved pages.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/offline_pages/client_policy_controller_unittest.cc

Issue 2473953006: Enable downloads UI for NTP-saved pages. (Closed)

Patch Set: Tests now pass. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java ('K') | « components/offline_pages/client_policy_controller.cc ('k') | components/offline_pages/downloads/download_notifying_observer_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "components/offline_pages/client_policy_controller.h"	5 #include "components/offline_pages/client_policy_controller.h"

6	6

7 #include <algorithm>	7 #include <algorithm>

8	8

9 #include "base/bind.h"	9 #include "base/bind.h"

10 #include "base/time/time.h"	10 #include "base/time/time.h"

(...skipping 124 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
135 ExpectRecentTab(kDownloadNamespace, false);	135 ExpectRecentTab(kDownloadNamespace, false);

136 ExpectOnlyOriginalTab(kDownloadNamespace, false);	136 ExpectOnlyOriginalTab(kDownloadNamespace, false);

137 }	137 }

138	138

139 TEST_F(ClientPolicyControllerTest, CheckNTPSuggestionsDefined) {	139 TEST_F(ClientPolicyControllerTest, CheckNTPSuggestionsDefined) {

140 OfflinePageClientPolicy policy =	140 OfflinePageClientPolicy policy =

141 controller()->GetPolicy(kNTPSuggestionsNamespace);	141 controller()->GetPolicy(kNTPSuggestionsNamespace);

142 EXPECT_EQ(policy.name_space, kNTPSuggestionsNamespace);	142 EXPECT_EQ(policy.name_space, kNTPSuggestionsNamespace);

143 EXPECT_FALSE(isTemporary(policy));	143 EXPECT_FALSE(isTemporary(policy));

144 EXPECT_TRUE(controller()->IsRemovedOnCacheReset(kNTPSuggestionsNamespace));	144 EXPECT_TRUE(controller()->IsRemovedOnCacheReset(kNTPSuggestionsNamespace));

145 ExpectDownloadSupport(kNTPSuggestionsNamespace, false);	145 ExpectDownloadSupport(kNTPSuggestionsNamespace, true);

146 ExpectRecentTab(kNTPSuggestionsNamespace, false);	146 ExpectRecentTab(kNTPSuggestionsNamespace, false);

147 ExpectOnlyOriginalTab(kNTPSuggestionsNamespace, false);	147 ExpectOnlyOriginalTab(kNTPSuggestionsNamespace, false);

148 }	148 }

149	149

150 } // namespace offline_pages	150 } // namespace offline_pages

OLD	NEW