components/offline_pages/downloads/download_notifying_observer_unittest.cc - Issue 2473953006: Enable downloads UI for NTP-saved pages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/downloads/download_notifying_observer_unittest.cc

Issue 2473953006: Enable downloads UI for NTP-saved pages. (Closed)

Patch Set: Tests now pass. Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsConfig.java ('K') | « components/offline_pages/client_policy_controller_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/offline_pages/downloads/download_notifying_observer_unittest.cc

diff --git a/components/offline_pages/downloads/download_notifying_observer_unittest.cc b/components/offline_pages/downloads/download_notifying_observer_unittest.cc

index 0ebeaadf664543cae3266f632372b5be9ac44095..7d6f66117adc45ea9ee2a5e818f27a5461cebcc6 100644

--- a/components/offline_pages/downloads/download_notifying_observer_unittest.cc

+++ b/components/offline_pages/downloads/download_notifying_observer_unittest.cc

@@ -236,9 +236,8 @@ TEST_F(DownloadNotifyingObserverTest, OnCompletedFailure) {

}

TEST_F(DownloadNotifyingObserverTest, NamespacesNotVisibleInUI) {

- std::vector<std::string> name_spaces = {

- kBookmarkNamespace, kLastNNamespace, kCCTNamespace,

- kNTPSuggestionsNamespace, kDefaultNamespace};

+ std::vector<std::string> name_spaces = {kBookmarkNamespace, kLastNNamespace,

+ kCCTNamespace, kDefaultNamespace};

for (auto name_space : name_spaces) {

ClientId invisible_client_id(name_space, kTestGuid);