Remove BrowserThread::UnsafeGetMessageLoopForThread()

Remove BrowserThread::UnsafeGetMessageLoopForThread()

Replacing one weird MessageLoop::IsIdleForTesting() loop in
chrome/browser/ui/app_list/speech_recognizer_browsertest.cc
with content::RunAllPendingInMessageLoop(content::BrowserThread::IO);

And all other use cases by BrowserThread::GetTaskRunnerForThread().

BUG=661344
Committed: https://crrev.com/aeb8129a0f5c3829193312fed52595ffde9b7c8a
Cr-Commit-Position: refs/heads/master@{#429774}

[gab, 2016-11-02 20:38:45]

Description was changed from

==========
Remove BrowserThread::UnsafeGetMessageLoopForCurrentThread()

BUG=661344
==========

to

==========
Remove BrowserThread::UnsafeGetMessageLoopForThread()

Replacing one weird MessageLoop::IsIdleForTesting() loop in
chrome/browser/ui/app_list/speech_recognizer_browsertest.cc
with content::RunAllPendingInMessageLoop(content::BrowserThread::IO);

And all other use cases by BrowserThread::GetTaskRunnerForThread().

BUG=661344
==========

[gab, 2016-11-02 20:39:56]

gab@chromium.org changed reviewers:
+ jam@chromium.org

[gab, 2016-11-02 20:39:57]

@jam: PTAL, thanks!

[gab, 2016-11-02 20:41:28]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 20:42:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2016-11-02 20:44:41]

The CQ bit was unchecked by gab@chromium.org

[gab, 2016-11-02 20:45:08]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 20:45:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 20:48:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 20:48:47]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[gab, 2016-11-02 20:50:59]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 20:51:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 22:37:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 22:37:29]

Dry run: This issue passed the CQ dry run.

[gab, 2016-11-03 21:31:24]

@jam: friendly ping, thanks!

[jam, 2016-11-03 22:59:45]

lgtm, nice

[gab, 2016-11-03 23:10:45]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2016-11-03 23:11:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 02:55:52]

Description was changed from

==========
Remove BrowserThread::UnsafeGetMessageLoopForThread()

Replacing one weird MessageLoop::IsIdleForTesting() loop in
chrome/browser/ui/app_list/speech_recognizer_browsertest.cc
with content::RunAllPendingInMessageLoop(content::BrowserThread::IO);

And all other use cases by BrowserThread::GetTaskRunnerForThread().

BUG=661344
==========

to

==========
Remove BrowserThread::UnsafeGetMessageLoopForThread()

Replacing one weird MessageLoop::IsIdleForTesting() loop in
chrome/browser/ui/app_list/speech_recognizer_browsertest.cc
with content::RunAllPendingInMessageLoop(content::BrowserThread::IO);

And all other use cases by BrowserThread::GetTaskRunnerForThread().

BUG=661344
==========

[commit-bot: I haz the power, 2016-11-04 02:55:53]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-11-04 02:57:17]

Description was changed from

==========
Remove BrowserThread::UnsafeGetMessageLoopForThread()

Replacing one weird MessageLoop::IsIdleForTesting() loop in
chrome/browser/ui/app_list/speech_recognizer_browsertest.cc
with content::RunAllPendingInMessageLoop(content::BrowserThread::IO);

And all other use cases by BrowserThread::GetTaskRunnerForThread().

BUG=661344
==========

to

==========
Remove BrowserThread::UnsafeGetMessageLoopForThread()

Replacing one weird MessageLoop::IsIdleForTesting() loop in
chrome/browser/ui/app_list/speech_recognizer_browsertest.cc
with content::RunAllPendingInMessageLoop(content::BrowserThread::IO);

And all other use cases by BrowserThread::GetTaskRunnerForThread().

BUG=661344

Committed: https://crrev.com/aeb8129a0f5c3829193312fed52595ffde9b7c8a
Cr-Commit-Position: refs/heads/master@{#429774}
==========

[commit-bot: I haz the power, 2016-11-04 02:57:17]

Patchset 4 (id:??) landed as
https://crrev.com/aeb8129a0f5c3829193312fed52595ffde9b7c8a
Cr-Commit-Position: refs/heads/master@{#429774}