Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2476433002: Replace URLDataSource::MessageLoopForRequestPath() with TaskRunnerForRequestPath(). (Closed)

Created:
4 years, 1 month ago by gab
Modified:
4 years, 1 month ago
CC:
chromium-reviews, darin-cc_chromium.org, David Black, dhollowa+watch_chromium.org, donnd+watch_chromium.org, dougw+watch_chromium.org, jam, Jered, jfweitz+watch_chromium.org, kmadhusu+watch_chromium.org, melevin+watch_chromium.org, samarth+watch_chromium.org, skanuj+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace URLDataSource::MessageLoopForRequestPath() with TaskRunnerForRequestPath(). This is inline with ongoing work to generalize MessageLoop usage towards TaskRunners. BUG=661344 Committed: https://crrev.com/143ea62ac9c872d88399ba2c7a81d3aa1f889fc1 Cr-Commit-Position: refs/heads/master@{#429545}

Patch Set 1 #

Patch Set 2 : rebase off local branch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -34 lines) Patch
M chrome/browser/search/suggestions/suggestions_ui.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/search/thumbnail_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/thumbnail_source.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/thumbnails/thumbnail_list_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/thumbnails/thumbnail_list_source.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/theme_source.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/theme_source.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/webui/shared_resources_data_source.h View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/webui/shared_resources_data_source.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/webui/url_data_manager_backend.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M content/public/browser/url_data_source.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/public/browser/url_data_source.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 19 (14 generated)
gab
@jochen PTAL, thanks
4 years, 1 month ago (2016-11-02 20:31:24 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 1 month ago (2016-11-03 11:55:51 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2476433002/40001
4 years, 1 month ago (2016-11-03 12:35:01 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 1 month ago (2016-11-03 12:47:30 UTC) #17
commit-bot: I haz the power
4 years, 1 month ago (2016-11-03 12:51:01 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/143ea62ac9c872d88399ba2c7a81d3aa1f889fc1
Cr-Commit-Position: refs/heads/master@{#429545}

Powered by Google App Engine
This is Rietveld 408576698