Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2470403002:
Inline CFRunLoopTimerSetTolerance() which is now available on all supported Mac versions (10.9+). (Closed)
|
Created:
4 years, 1 month ago by gab Modified:
4 years, 1 month ago Reviewers:
Mark Mentovai CC:
chromium-reviews, sadrul, mac-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionInline CFRunLoopTimerSetTolerance() which is now available on all supported Mac versions (10.9+).
BUG=662015
NO_DEPENDENCY_CHECKS=true
Committed: https://crrev.com/be6db82023de49b9ccee22b28982f8deb57739f8
Cr-Commit-Position: refs/heads/master@{#429898}
Patch Set 1 #
Depends on Patchset: Dependent Patchsets: Messages
Total messages: 21 (13 generated)
The CQ bit was checked by gab@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
gab@chromium.org changed reviewers: + mark@chromium.org
Mark PTAL. I think this code might run on iOS as well. According to https://developer.apple.com/reference/corefoundation/1542980-cfrunlooptimerse... this is iOS7+, do we support anything below that? (I'm expecting CQ to choke if so but maybe you know as well)
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM
The CQ bit was checked by gab@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
This CL has an open dependency (Issue 2473823002 Patch 60001). Please resolve the dependency and try again. If you are sure that there is no real dependency, please use one of the options listed in https://goo.gl/9Es4OR to land the CL.
Description was changed from ========== Inline CFRunLoopTimerSetTolerance() which is now available on all supported Mac versions (10.9+). BUG=662015 ========== to ========== Inline CFRunLoopTimerSetTolerance() which is now available on all supported Mac versions (10.9+). BUG=662015 NO_DEPENDENCY_CHECKS=true ==========
The CQ bit was checked by gab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
The CQ bit was checked by gab@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Inline CFRunLoopTimerSetTolerance() which is now available on all supported Mac versions (10.9+). BUG=662015 NO_DEPENDENCY_CHECKS=true ========== to ========== Inline CFRunLoopTimerSetTolerance() which is now available on all supported Mac versions (10.9+). BUG=662015 NO_DEPENDENCY_CHECKS=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Inline CFRunLoopTimerSetTolerance() which is now available on all supported Mac versions (10.9+). BUG=662015 NO_DEPENDENCY_CHECKS=true ========== to ========== Inline CFRunLoopTimerSetTolerance() which is now available on all supported Mac versions (10.9+). BUG=662015 NO_DEPENDENCY_CHECKS=true Committed: https://crrev.com/be6db82023de49b9ccee22b28982f8deb57739f8 Cr-Commit-Position: refs/heads/master@{#429898} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/be6db82023de49b9ccee22b28982f8deb57739f8 Cr-Commit-Position: refs/heads/master@{#429898} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
