Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2473393002: Add missing virtual destructor to backend callbacks. (Closed)

Created:
4 years, 1 month ago by Eric Seckler
Modified:
4 years, 1 month ago
Reviewers:
kozy, dgozman
CC:
chromium-reviews, devtools-reviews_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add missing virtual destructor to backend callbacks. The missing virtual destructors are causing hard to diagnose delete size mismatch failures if used with tcmalloc, because the superclass destructors are called instead of the subclass ones. Previously, they were not necessary because the destructor was declared virtual through the old BackendCallback base class (which was removed as of https://codereview.chromium.org/2468923002). BUG=none R=kozyatinskiy@chromium.org Committed: https://chromium.googlesource.com/deps/inspector_protocolebda02bf94a742a2e26e4f818df1fc77517ac44c

Patch Set 1 #

Patch Set 2 : Intendation fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M templates/TypeBuilder_h.template View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Eric Seckler
4 years, 1 month ago (2016-11-04 12:34:54 UTC) #2
Eric Seckler
On 2016/11/04 12:34:54, Eric Seckler wrote: Missing _de_structors of course :)
4 years, 1 month ago (2016-11-04 12:35:37 UTC) #4
kozy
lgtm
4 years, 1 month ago (2016-11-04 14:27:56 UTC) #7
Sami
4 years, 1 month ago (2016-11-04 14:46:17 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ebda02bf94a742a2e26e4f818df1fc77517ac44c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698